Skip to content

Show the selected label name in the delete confirmation dialog - #1122

Draft
Crustack with Copilot wants to merge 2 commits into
mainfrom
copilot/show-label-name-in-delete-dialog
Draft

Crustack with Copilot wants to merge 2 commits into
mainfrom
copilot/show-label-name-in-delete-dialog

Conversation

Copilot AI commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

The label deletion confirmation dialog did not identify which label was being removed, making mis-taps easy to miss. This updates the dialog to show the selected label name inline while preserving the existing confirmation flow.

  • Dialog clarity

    • Include the label name in the delete confirmation popup so the target label is visible before confirming.
    • Keep the existing title, warning text, and delete action unchanged.
  • Coverage

    • Add a focused Robolectric test for the label deletion dialog message to verify the selected label name is surfaced.
  • Implementation

    MaterialAlertDialogBuilder(requireContext())
        .setTitle(R.string.delete_label)
        .setMessage("$value\n\n${getString(R.string.your_notes_associated)}")
        .setPositiveButton(R.string.delete) { _, _ -> model.deleteLabel(value) }

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d8588672-65ec-4605-ae09-a6f8c2b6f4cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI linked an issue Sep 19, 2026 that may be closed by this pull request
Co-authored-by: Crustack <39240633+Crustack@users.noreply.github.com>
Copilot AI changed the title [WIP] Add label name to delete dialog confirmation Show the selected label name in the delete confirmation dialog Sep 19, 2026
Copilot AI requested a review from Crustack September 19, 2026 07:42
@Crustack
Crustack force-pushed the main branch 2 times, most recently from d69f1d9 to 60ae83b Compare September 20, 2026 11:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show label name in delete dialog

2 participants