Update deprecated ghcr.io image reference to public.ecr.aws - #40
Update deprecated ghcr.io image reference to public.ecr.aws#40luisina-santos wants to merge 1 commit into
Conversation
README.md referenced this connector's image via ghcr.io/conductorone; container images are now published to public.ecr.aws/conductorone instead. Only this connector's own image reference was updated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.awsBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review Summary Security Issues Correctness Issues Suggestions
Prompt for AI agents |
| ``` | ||
| docker run --rm -v $(pwd):/out -e BATON_DSN="server=127.0.0.1;user id=sa;password=devP@ssw0rd;port=1433" ghcr.io/conductorone/baton-sql-server:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out -e BATON_DSN="server=127.0.0.1;user id=sa;password=devP@ssw0rd;port=1433" public.ecr.aws/conductorone/baton-sql-server:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources |
There was a problem hiding this comment.
🟡 Suggestion: This second command still pulls the baton CLI from ghcr.io/conductorone/baton:latest, one line below the connector image you just moved to public.ecr.aws. The PR description says that was intentional scope-limiting, so this is non-blocking — but if ghcr.io is being retired, users copy/pasting this block will hit a dead reference. Worth a follow-up once the baton CLI image is confirmed published on public.ecr.aws.
Summary
ghcr.io/conductorone/baton-sql-server:latest; container images are now published topublic.ecr.aws/conductorone/baton-sql-server:latestinstead.Test plan
public.ecr.aws/conductorone/baton-sql-server:latestresolves (manifest exists) before opening this PR.🤖 Generated with Claude Code