Skip to content

Replace deprecated assertThat and IOUtils.toString() calls #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwalluck merged 1 commit into from
Aug 28, 2026
Merged

Replace deprecated assertThat and IOUtils.toString() calls #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions junit4/src/test/java/org/commonjava/test/http/junt4/TestHttpServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@

import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.StandardCharsets;

import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.notNullValue;
import static org.junit.Assert.assertThat;
import static org.hamcrest.MatcherAssert.assertThat;

public class TestHttpServerTest
{
Expand Down Expand Up @@ -94,7 +95,7 @@ private String getHttpContent(String url) throws IOException
try(CloseableHttpResponse response = client.execute( request ))
{
InputStream stream = response.getEntity().getContent();
return IOUtils.toString( stream );
return IOUtils.toString( stream, StandardCharsets.UTF_8 );
}
finally
{
Expand Down
3 changes: 2 additions & 1 deletion junit5/src/test/java/org/commonjava/test/http/junit5/AbstractExtensionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.junit.jupiter.api.Test;

import java.io.InputStream;
import java.nio.charset.StandardCharsets;

import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
Expand Down Expand Up @@ -91,7 +92,7 @@ public void simpleDownload()
{
response = client.execute( request );
stream = response.getEntity().getContent();
final String result = IOUtils.toString( stream );
final String result = IOUtils.toString( stream, StandardCharsets.UTF_8 );

assertThat( result, notNullValue() );
assertThat( result, equalTo( content ) );
Expand Down
3 changes: 2 additions & 1 deletion quarkus/src/test/java/org/commonjava/test/http/quarkus/TestHttpServerWithQuarkus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.junit.jupiter.api.Test;

import java.io.InputStream;
import java.nio.charset.StandardCharsets;

import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
Expand Down Expand Up @@ -94,7 +95,7 @@ public void simpleDownload()
{
response = client.execute( request );
stream = response.getEntity().getContent();
final String result = IOUtils.toString( stream );
final String result = IOUtils.toString( stream, StandardCharsets.UTF_8 );

assertThat( result, notNullValue() );
assertThat( result, equalTo( content ) );
Expand Down