Test for a free port instead of guessing from a restricted range - #68
Open
dwalluck wants to merge 1 commit into
Open
Test for a free port instead of guessing from a restricted range#68dwalluck wants to merge 1 commit into
dwalluck wants to merge 1 commit into
Conversation
Fix retry not handling `RuntimeException`. Record the last exception.
Contributor
|
Looks like the code was changed and commented out by @jdcasey with a comment about a race condition |
Contributor
Author
Let me list the issues I found with the current code and why I changed anything at all since I didn't put a thorough commit message:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix retry not handling
RuntimeException.Record the last exception.