Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 96.73% 96.74% +0.01%
==========================================
Files 1069 1070 +1
Lines 138549 138920 +371
==========================================
+ Hits 134023 134397 +374
+ Misses 4526 4523 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isPANN
marked this pull request as draft
September 26, 2026 03:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several reductions marked target parameters unavailable even though their constructed values have exact formulas in registered source parameters. This PR adds 24 such formulas across 22 rules. For example, ExactCoverBy3Sets → ILP now reports
num_nonzeros = 4 * num_subsets. HamiltonianPath → ILP reports all three ILP sizes exactly, including the empty-graph case, using a source parameter for consecutive positions. BMF → BicliqueCover no longer claims an exact edge count from matrix dimensions alone.One registry-wide test checks every declared formula field against a constructed target: equality for
exact, and predicted ≥ measured forupper_bound. It uses canonical examples or registered generators where examples are unavailable. Turing Decision wrappers and two proof-only rules have test-only target constructions because they have no single-shot reduction callback. This check caught a false QUBO → SpinGlass exact claim: sparse QUBOs do not havenum_vars²interactions. QUBO now exposes its natural nonzero quadratic-term count, which restores an exact interaction formula and also makes all three QUBO → ILP size formulas exact. The canonical instructions and add-rule guide now require coverage for every formula field in future rules.Validation:
make checkpassed (formatting, Clippy, workspace tests, and doctests).