Repository navigation
Conversation
fix(ops): restore task skills and verified web lead updates
fix(ops): preserve trigger parent for web lead updates
docs(ops): record verified website release and notification
fix: reduce duplicate agent handoffs and completion churn
docs: record agent handoff rollout and rollback
chore: upgrade fork to latest upstream Multica
There was a problem hiding this comment.
The PR successfully fixes the channel prompt issue by separating conversation history boundaries from CLI issue lookup capabilities. The implementation is well-structured with comprehensive test coverage verifying the new behavior. No critical defects found that would block merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a channel prompt that prevented Web Lead from reading CLP-104 even after Anh supplied its issue ID and link. The prompt now keeps channel history separate from issue evidence and explicitly allows retrieving a referenced issue through the CLI within the agent’s existing role and access.
Related Issue
Observed in CLP-104.
Type of Change
Changes Made
How to Test
go test ./internal/daemon -run TestBuildChatPrompt -count=1passed on this branch.go test ./internal/daemon/... -count=1passed on the existing worker revision with this patch. On this PR base, daemon, execenv and processtree passed; repocache failed in the combined run and passed on an isolated rerun.2ae2dbbb8source revision with only this patch. The Singapore worker was replaced while idle, with its previous binary retained, and all 19 runtimes registered. Live Lark lookup verification is pending an authorized mention.Risks
The wording affects channel-backed agent runs. Existing server authorization and Agent Identity restrictions remain authoritative; this changes no grants or credentials. Web Lead separately lacks Lark message-read scope, which still limits history/quote retrieval. That app permission requires its administrator and is not changed by this PR.
Checklist
AI Disclosure
AI tool used: Codex
Prompt / approach: Trace Web Lead’s refusal from the Lark reply to its actual generated runtime prompt and permission errors; make the smallest prompt correction and test the history/issue distinction. No model or access setting was changed.