Skip to content

fix(daemon): allow referenced issue lookup in channel chats - #14

Open
harley wants to merge 18 commits into
mainfrom
fix/channel-referenced-issue-lookup
Open

harley wants to merge 18 commits into
mainfrom
fix/channel-referenced-issue-lookup

Conversation

@harley

@harley harley commented Oct 8, 2026 •

Copy link
Copy Markdown

What does this PR do?

Fixes a channel prompt that prevented Web Lead from reading CLP-104 even after Anh supplied its issue ID and link. The prompt now keeps channel history separate from issue evidence and explicitly allows retrieving a referenced issue through the CLI within the agent’s existing role and access.

Related Issue

Observed in CLP-104.

Type of Change

  • Bug fix
  • Tests

Changes Made

  • Replace the unconditional ban on reading issues/comments with a conversation-history boundary.
  • Explain that failed quotes or unavailable history do not prevent lookup of an explicitly referenced issue.
  • Keep role, access and permission limits explicit; cover Slack, Lark, WeCom, DingTalk and unknown channels.

How to Test

  1. go test ./internal/daemon -run TestBuildChatPrompt -count=1 passed on this branch.
  2. All packages in go test ./internal/daemon/... -count=1 passed on the existing worker revision with this patch. On this PR base, daemon, execenv and processtree passed; repocache failed in the combined run and passed on an isolated rerun.
  3. GitHub CI passed for the PR head, including backend tests, channel-agent tests, frontend tests/builds, installer checks and vulnerability scanning.
  4. A Linux worker binary was built from its existing 2ae2dbbb8 source revision with only this patch. The Singapore worker was replaced while idle, with its previous binary retained, and all 19 runtimes registered. Live Lark lookup verification is pending an authorized mention.

Risks

The wording affects channel-backed agent runs. Existing server authorization and Agent Identity restrictions remain authoritative; this changes no grants or credentials. Web Lead separately lacks Lark message-read scope, which still limits history/quote retrieval. That app permission requires its administrator and is not changed by this PR.

Checklist

  • Included context and reasoning
  • Added regression coverage
  • Documented risks and operational verification limits
  • Live Lark regression completed

AI Disclosure

AI tool used: Codex

Prompt / approach: Trace Web Lead’s refusal from the Lark reply to its actual generated runtime prompt and permission errors; make the smallest prompt correction and test the history/issue distinction. No model or access setting was changed.

harley and others added 18 commits September 21, 2026 22:07
fix(ops): restore task skills and verified web lead updates
fix(ops): preserve trigger parent for web lead updates
docs(ops): record verified website release and notification
fix: reduce duplicate agent handoffs and completion churn
docs: record agent handoff rollout and rollback
chore: upgrade fork to latest upstream Multica

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR successfully fixes the channel prompt issue by separating conversation history boundaries from CLI issue lookup capabilities. The implementation is well-structured with comprehensive test coverage verifying the new behavior. No critical defects found that would block merge.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant