Repository navigation
Conversation
|
View your CI Pipeline Execution ↗ for commit 990e970 ☁️ Nx Cloud last updated this comment at |
dreamwasp
changed the title
|
4 of 6 tasks
deepmerge@4.3.1 (transitive via react-player, used in the Video component) has no upstream fix for a prototype pollution vuln. Patch mergeObject's unsafe-key check to reject __proto__/constructor/prototype keys, and pin all in-tree deepmerge ranges to the patched build via yarn resolutions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dreamwasp
force-pushed
the
cass-gmt-deepmerge-fix
branch
from
September 23, 2026 19:36
3c31d4d to
990e970
Compare
dreamwasp
changed the title
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6ab42b8f5435b96c57ab3e1f--gamut-preview.netlify.app |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deepmerge@4.3.1(transitive viareact-player, used in theVideocomponent) has a prototype pollution vuln (CVE-2026-93753, CVSS 8.7, SNYK-JS-DEEPMERGE-19964053) with no upstream fix.deepmerge'smergeObjectto reject__proto__/constructor/prototypekeys in its unsafe-key check (.yarn/patches/deepmerge-npm-4.3.1-4f751a0844.patch), applied viayarn patch.deepmergesemver ranges (^4.0.0,^4.2.2,^4.3.1) to the patched build viaresolutionsinpackage.json.We also explored upgrading
react-playerto v3, which dropsdeepmergeentirely — see #3439. That's parked for now: it hard-breaks Codecademy's build (webpack 4 can't resolve v3's dependency chain, which relies on package.jsonexportsmaps with no fallback), so this patch is the safer near-term fix.Test plan
deepmerge({}, JSON.parse('{"__proto__":{"polluted":"yes"}}'))no longer setsObject.prototype.polluted)yarn jest packages/gamut— 110 suites / 1459 tests pass🤖 Generated with Claude Code