Skip to content

LONDON | ITP-May-26 | Rizqah Popoola | Sprint 3 | Project TV Show - #92

Open
risikatpopoola wants to merge 27 commits into
CodeYourFuture:mainfrom
risikatpopoola:level-500
Open

LONDON | ITP-May-26 | Rizqah Popoola | Sprint 3 | Project TV Show#92
risikatpopoola wants to merge 27 commits into
CodeYourFuture:mainfrom
risikatpopoola:level-500

Conversation

@risikatpopoola

@risikatpopoola risikatpopoola commented Aug 19, 2026

Copy link
Copy Markdown

##Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | SPRINT NUM | PROJECT NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

The changes satisfy the requirements:

  1. Level-100: Episode Listing Display
  2. Level-200: Live Episode Search
  3. Level-300: Episode Selector Dropdown
  4. Level-400: API Fetch and Show Selector
  5. Level-500: Shows Listing Page and Caching, in detail:
  • Initial app load presents full listing of all shows.
  • Each show card displays name, image, summary, genres, status, rating, and runtime.
  • Clicking any show title switches to that show's episode view and hides shows listing.
  • Navigation button returns to shows listing and hides episode listing.
  • Free-text show search filters shows by name, summary, and genres.
  • Search and dropdown controls work cleanly when switching back and forth between views.
  • API response caching: no URL endpoint is fetched more than once per visit.
  • Netlify url: https://cyf-risikatpopoola-tv.netlify.app/
  • Partners name is Dipa Sarker

risikatpopoola and others added 27 commits August 8, 2026 11:07
github username and name added to index.html
LONDON | ITP-May-26 | Dipa Sarker| Sprint 2 | Project TV Show Level 200-Search
…ode-selector

LONDON | ITP-May-26 | Dipa Sarker | Sprint 2 | Project TV Show level 200- episode selector
LONDON | ITP-May-26 | Dipa Sarker| Sprint 3 | Project TV Show-level 300-refactoring
LONDON | ITP-May-26 | Dipa Sarker | Sprint 3 | Project TV Show- level 400
@risikatpopoola risikatpopoola changed the title LONDON | ITP-May-26 | Rizqah Popoola | Sprint 4 | Project TV Show LONDON | ITP-May-26 | Rizqah Popoola | Sprint 3 | Project TV Show Aug 19, 2026
@risikatpopoola risikatpopoola added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module labels Aug 19, 2026
@risikatpopoola risikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 19, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 7, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this. You've used pretty good semantic HTML and templates. The code is generally well written and laid out. The functionality is pretty good.

I have spotted a few minor things though, and some extra questions. if you want an extra challenge now the ITP is over, you can try to address them.

Comment thread index.html
<label for="show-selector">Choose A Show:</label>
<select id="show-selector"></select>
<label for="episode-selector">Choose an episode:</label>
<select id="episode-selector"></select>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before a show is selected, the user is presented with this blank select menu. Is there a way we could improve the UI here?

Comment thread style.css
color: var(--dark);
}

img {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking at this on a machine with a large screen, the images look very expanded and blurry. Could that be avoided?

Comment thread script.js
// BACK TO SHOWS

backToShowsButton.addEventListener("click", function () {
viewingShows = true;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the application state being properly changed? e.g. When going "back to shows", are there any controls you can still interact with that are specific to episodes?

Comment thread script.js
// SORT SHOWS ALPHABETICALLY

allShows.sort((show1, show2) => {
if (show1.name.toLowerCase() > show2.name.toLowerCase()) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code seems quite complex and contains some repetition. could it be simplified?

Comment thread script.js
card.style.display = "none";
});

selectedCard.style.display = "block";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When searching, you re-make the elements. When picking an episode, you hide all but the selected one. What do you think of these two different approaches?

Comment thread script.js

card.querySelector(".show-image").src = show.image?.medium || "";

card.querySelector(".show-image").alt = show.name;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best way to use this alt tag? See what https://axesslab.com/alt-texts/ has to say

Comment thread script.js

card.querySelector(".show-image").alt = show.name;

card.querySelector(".show-summary").innerHTML =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there are any potential side effects of setting the HTML this way?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants