LONDON | ITP-May-26 | Rizqah Popoola | Sprint 3 | Project TV Show - #92
LONDON | ITP-May-26 | Rizqah Popoola | Sprint 3 | Project TV Show#92risikatpopoola wants to merge 27 commits into
Conversation
github username and name added to index.html
Tvproject level 100
LONDON | ITP-May-26 | Dipa Sarker| Sprint 2 | Project TV Show Level 200-Search
…ode-selector LONDON | ITP-May-26 | Dipa Sarker | Sprint 2 | Project TV Show level 200- episode selector
Level 300 apifetch
LONDON | ITP-May-26 | Dipa Sarker| Sprint 3 | Project TV Show-level 300-refactoring
LONDON | ITP-May-26 | Dipa Sarker | Sprint 3 | Project TV Show- level 400
Level 400 refactoring
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this. You've used pretty good semantic HTML and templates. The code is generally well written and laid out. The functionality is pretty good.
I have spotted a few minor things though, and some extra questions. if you want an extra challenge now the ITP is over, you can try to address them.
| <label for="show-selector">Choose A Show:</label> | ||
| <select id="show-selector"></select> | ||
| <label for="episode-selector">Choose an episode:</label> | ||
| <select id="episode-selector"></select> |
There was a problem hiding this comment.
Before a show is selected, the user is presented with this blank select menu. Is there a way we could improve the UI here?
| color: var(--dark); | ||
| } | ||
|
|
||
| img { |
There was a problem hiding this comment.
When looking at this on a machine with a large screen, the images look very expanded and blurry. Could that be avoided?
| // BACK TO SHOWS | ||
|
|
||
| backToShowsButton.addEventListener("click", function () { | ||
| viewingShows = true; |
There was a problem hiding this comment.
Is the application state being properly changed? e.g. When going "back to shows", are there any controls you can still interact with that are specific to episodes?
| // SORT SHOWS ALPHABETICALLY | ||
|
|
||
| allShows.sort((show1, show2) => { | ||
| if (show1.name.toLowerCase() > show2.name.toLowerCase()) { |
There was a problem hiding this comment.
This block of code seems quite complex and contains some repetition. could it be simplified?
| card.style.display = "none"; | ||
| }); | ||
|
|
||
| selectedCard.style.display = "block"; |
There was a problem hiding this comment.
When searching, you re-make the elements. When picking an episode, you hide all but the selected one. What do you think of these two different approaches?
|
|
||
| card.querySelector(".show-image").src = show.image?.medium || ""; | ||
|
|
||
| card.querySelector(".show-image").alt = show.name; |
There was a problem hiding this comment.
Is this the best way to use this alt tag? See what https://axesslab.com/alt-texts/ has to say
|
|
||
| card.querySelector(".show-image").alt = show.name; | ||
|
|
||
| card.querySelector(".show-summary").innerHTML = |
There was a problem hiding this comment.
Do you think there are any potential side effects of setting the HTML this way?
##Self checklist
Changelist
The changes satisfy the requirements: