London | 26-ITP-Sep | Phoebe Wong | Sprint 1 | Form Controls - #1477
Open
wongphoebe wants to merge 8 commits into
Open
London | 26-ITP-Sep | Phoebe Wong | Sprint 1 | Form Controls#1477wongphoebe wants to merge 8 commits into
wongphoebe wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wongphoebe
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
wongphoebe
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
wongphoebe
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Sep 11, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
|
|
||
|
|
||
| <!-- Radio Button for T-shirt Size--> | ||
| <fieldset> |
There was a problem hiding this comment.
FYI: I would change the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
Author
There was a problem hiding this comment.
Got it and absolutely agree with that. Thank you so much!
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Create form for data collection about T-shirt purchase.
Questions
I'd like to know if CSS is mainly for formatting the style of the form? Because I completed this task without using CSS, but is trying to know if I should. Thanks.