Skip to content

ChipField: Respect parent form Disabled and ReadOnly state #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redgp0g wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ChipField: Respect parent form Disabled and ReadOnly state #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CodeBeam.MudBlazor.Extensions/Components/ChipField/MudChipField.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
@for (int i = 0; i < (MaxChips == 0 ? _valuesState.Value?.Count ?? 0 : (MaxChips < (_valuesState.Value?.Count ?? 0) ? MaxChips : _valuesState.Value?.Count ?? 0)); i++)
{
int a = i;
<MudChip T="T" Class="@ClassChip" Style="@StyleChip" Ripple="false" Text="@(_valuesState.Value != null ? _valuesState.Value[a] : string.Empty)" Color="@ChipColor" Variant="@ChipVariant" Size="@ChipSize" Disabled="@Disabled" />
<MudChip T="T" Class="@ClassChip" Style="@StyleChip" Ripple="false" Text="@(_valuesState.Value != null ? _valuesState.Value[a] : string.Empty)" Color="@ChipColor" Variant="@ChipVariant" Size="@ChipSize" Disabled="@GetDisabledState()" />
}
</MudChipSet>
@if (_valuesState.Value != null && MaxChips != 0 && MaxChips < _valuesState.Value.Count)
{
<MudChip T="T" Ripple="false" Text="@($"+{_valuesState.Value.Count - MaxChips}")" Color="@ChipColor" Variant="@ChipVariant" Size="@ChipSize" Disabled="@Disabled" />
<MudChip T="T" Ripple="false" Text="@($"+{_valuesState.Value.Count - MaxChips}")" Color="@ChipColor" Variant="@ChipVariant" Size="@ChipSize" Disabled="@GetDisabledState()" />
}
</DataVisualiser>

Expand Down
2 changes: 1 addition & 1 deletion src/CodeBeam.MudBlazor.Extensions/Components/ChipField/MudChipField.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ protected async Task SetChips()
/// <returns></returns>
public async Task Closed(MudChip<T> chip)
{
if (Disabled || ReadOnly)
if (GetDisabledState() || GetReadOnlyState())
{
return;
}
Expand Down
21 changes: 21 additions & 0 deletions ...dBlazor.Extensions.UnitTests.Viewer/TestComponents/ChipField/ChipFieldFormStateTest.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
@namespace MudExtensions.UnitTests.TestComponents

<MudSwitch T="bool" @bind-Value="FormDisabled" Label="Form Disabled" Color="Color.Primary" />
<MudSwitch T="bool" @bind-Value="FormReadOnly" Label="Form ReadOnly" Color="Color.Primary" />

<MudForm Disabled="@FormDisabled" ReadOnly="@FormReadOnly">
<MudChipField T="string" @bind-Values="Values" Label="Chip Field" Variant="Variant.Outlined" />
</MudForm>

@code {
public static string __description__ = "Chips should respect the parent form's Disabled and ReadOnly state";

[Parameter]
public bool FormDisabled { get; set; }

[Parameter]
public bool FormReadOnly { get; set; }

[Parameter]
public List<string>? Values { get; set; } = new() { "first", "second" };
}
33 changes: 33 additions & 0 deletions tests/CodeBeam.MudBlazor.Extensions.UnitTests/Components/ChipFieldTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using Bunit;
using AwesomeAssertions;
using Microsoft.AspNetCore.Components;
using MudBlazor;
using MudBlazor.Extensions;
using MudExtensions.UnitTests.TestComponents;

namespace MudExtensions.UnitTests.Components
{
Expand All @@ -21,5 +23,36 @@ public async Task ChipFieldBasicTest()
comp.Instance.GetState(x => x.Values).Should().BeEquivalentTo(new List<string> { "asdf", "asd", "sdfg" });
comp.Instance.GetState(x => x.Value).Should().BeEquivalentTo(null);
}

[Test]
public async Task ChipField_ParentFormDisabled_ShouldDisableChipsAndPreventRemoval()
{
var comp = Context.Render<ChipFieldFormStateTest>(opt =>
{
opt.Add(a => a.FormDisabled, true);
});
var chipField = comp.FindComponent<MudChipField<string>>();
var chips = comp.FindComponents<MudChip<string>>();

chips.Should().HaveCount(2);
chips.Should().AllSatisfy(chip => chip.Instance.Disabled.Should().BeTrue());

await comp.InvokeAsync(() => chipField.Instance.Closed(chips[0].Instance));
chipField.Instance.GetState(x => x.Values).Should().BeEquivalentTo(new List<string> { "first", "second" });
}

[Test]
public async Task ChipField_ParentFormReadOnly_ShouldPreventRemoval()
{
var comp = Context.Render<ChipFieldFormStateTest>(opt =>
{
opt.Add(a => a.FormReadOnly, true);
});
var chipField = comp.FindComponent<MudChipField<string>>();
var chips = comp.FindComponents<MudChip<string>>();

await comp.InvokeAsync(() => chipField.Instance.Closed(chips[0].Instance));
chipField.Instance.GetState(x => x.Values).Should().BeEquivalentTo(new List<string> { "first", "second" });
}
}
}