Repository navigation
Feat/metricstore missing data summary - #593
Merged
Merged
Conversation
MemoryStore.Read warned once per buffer that did not cover the requested window. A node-scope read of a metric stored per hwthread aggregates every hwthread buffer, so a node missing data produced one line per metric and child scope on every request. FetchData and FetchStats now collect the gaps of all reads in a request and log one line per host with the affected metrics, the number of gapped buffers and the largest front/back gap. The new top-level metricstore option "verbose-missing-data" restores the previous per-buffer warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The per-node summary now lists only the affected metrics and the largest front/back gap. The buffer count is still tracked internally to detect reads with gaps, but is no longer printed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The per-node summary no longer lists the names of the affected metrics or the verbose-mode hint; it reports the number of affected metrics and the largest front/back gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion Remove the verbose-missing-data option. The per-buffer "does not align" lines are now always logged at debug level (skipped entirely unless the log level is debug), while FetchData and FetchStats keep warning once per host and request with the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.