Skip to content

Feat/metricstore missing data summary - #593

Merged
adityauj merged 5 commits into
mainfrom
feat/metricstore-missing-data-summary
Nov 18, 2026
Merged

adityauj merged 5 commits into
mainfrom
feat/metricstore-missing-data-summary

Conversation

@adityauj

Copy link
Copy Markdown
Member

No description provided.

adityauj and others added 4 commits November 17, 2026 13:35
MemoryStore.Read warned once per buffer that did not cover the requested
window. A node-scope read of a metric stored per hwthread aggregates every
hwthread buffer, so a node missing data produced one line per metric and
child scope on every request.

FetchData and FetchStats now collect the gaps of all reads in a request
and log one line per host with the affected metrics, the number of gapped
buffers and the largest front/back gap. The new top-level metricstore
option "verbose-missing-data" restores the previous per-buffer warnings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The per-node summary now lists only the affected metrics and the largest
front/back gap. The buffer count is still tracked internally to detect
reads with gaps, but is no longer printed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The per-node summary no longer lists the names of the affected metrics or
the verbose-mode hint; it reports the number of affected metrics and the
largest front/back gap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion

Remove the verbose-missing-data option. The per-buffer "does not align"
lines are now always logged at debug level (skipped entirely unless the
log level is debug), while FetchData and FetchStats keep warning once per
host and request with the summary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adityauj
adityauj merged commit e5a5cef into main Nov 18, 2026
2 checks passed
@adityauj
adityauj deleted the feat/metricstore-missing-data-summary branch November 18, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant