Skip to content

Isolate OIDC subjects, client roles and callback redirects - #591

Open
robertexternbrink wants to merge 3 commits into
ClusterCockpit:mainfrom
robertexternbrink:fix/BE17-oidc-integrity
Open

robertexternbrink wants to merge 3 commits into
ClusterCockpit:mainfrom
robertexternbrink:fix/BE17-oidc-integrity

Conversation

@robertexternbrink

Copy link
Copy Markdown

Restrict client roles to the configured application and reject UserInfo subjects that differ from the verified ID token. Keep redirect URIs request-specific; foreign client roles with matching privileged mappings can otherwise grant local rights, and concurrent login flows can interfere.

Validation: The auth package passed locally normally and with race checks. Regression tests use a local signing provider and actual session middleware.

@spacehamster87 spacehamster87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants