Repository navigation
Preserve routing and drain accepted NATS ingestion on shutdown - #589
Open
robertexternbrink wants to merge 6 commits into
Open
robertexternbrink wants to merge 6 commits into
robertexternbrink wants to merge 6 commits into
Conversation
Audit finding: BUG-0014
Audit findings: BUG-0009, BUG-0014, BUG-0054
Audit finding: BUG-0047
Audit finding: BUG-0048
Audit findings: BUG-0047, BUG-0048, BUG-0049
spacehamster87
left a comment
Contributor
There was a problem hiding this comment.
A few flagged notes, otherwise in favor of the PR 👍
- New fatal on startup: Subscription errors now end in cclog.Fatal (os.Exit(1)). In practice this fires for a malformed
subscribe-tosubject, where previously the subscription was silently missing (and the log falsely said "established"). While failing fast is reasonable, it is a behaviour change: one bad subject now stops the whole backend, including the web UI. Is that intended, or should it log and continue with the remaining subscriptions? @moebiusband73 - Delayed NATS server is fine: Since cc-lib connects with
RetryOnFailedConnect(true)and unlimited reconnects, an unreachable server at startup does not trigger the new fatal. @ipatix - Merge order with PR588: The
DecodeLinehunk here still useslvl/GetLevel, which PR588 removes. Whichever lands second needs a rebase; after PR588 the new check simply becomesprevCluster, prevHost = cluster, host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve routing from each sample’s effective tags and carry subscription defaults with queued NATS messages. Propagate reader/subscription failures and drain accepted ingestion before the final checkpoint to prevent misrouting, callback races and shutdown data loss.
Validation: Full metricstore tests, including race checks, and build/vet passed locally. Checks used the published cc-lib v2.17.0 and line-protocol v2.4.0 dependencies without local replacements.