Skip to content

Checkpoint accepted changes to restored metric buffers - #587

Open
robertexternbrink wants to merge 2 commits into
ClusterCockpit:mainfrom
robertexternbrink:fix/BE01-checkpoint-restore
Open

robertexternbrink wants to merge 2 commits into
ClusterCockpit:mainfrom
robertexternbrink:fix/BE01-checkpoint-restore

Conversation

@robertexternbrink

Copy link
Copy Markdown

Mark accepted mutations to restored buffers as dirty and retain the latest snapshot overlapping the restore window. Otherwise subsequent checkpoints can omit accepted updates and restoration can drop retained samples.

Validation: Checkpoint mutation/overlap regressions and the metricstore package passed locally, including race checks.

@spacehamster87 spacehamster87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants