Skip to content

add get_compatible_units function - #238

Merged
kroenlein merged 1 commit into
mainfrom
compatible-units
Oct 16, 2026
Merged

kroenlein merged 1 commit into
mainfrom
compatible-units

Conversation

@robbtraister

Copy link
Copy Markdown

GEMD Python PR

Description

Expose a get_compatible_units that allows the caller to fetch a complete list of all known units that have the same dimensions as the provided argument.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@robbtraister
robbtraister marked this pull request as ready for review October 15, 2026 16:07

@kroenlein kroenlein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but this list will probably be a mess.

@kroenlein
kroenlein merged commit 20d35f2 into main Oct 16, 2026
38 checks passed
@kroenlein
kroenlein deleted the compatible-units branch October 16, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants