Conversation
RowInsertValues, RowUpdateValues and SheetQueryResponse.rows were generated with a second level of additional_properties, so a scalar cell value could not be represented in either direction: parsing a row of scalars raised ValueError, and serializing one raised AttributeError. This made get_sheet_data, query_sheet_data, query_namespace_data, insert_sheet_data and update_sheet_data unusable against any sheet holding data. The map values and row cells are free-form JSON, matching the Map<String, Object> and List<List<Object>> the API actually serves, so these models now carry a single level of additional_properties like Sample.metadata. The source spec still declares these as `type: object`; until that is corrected the next schema sync will reintroduce the nested models. Fixes #29 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RowInsertValues,RowUpdateValuesandSheetQueryResponse.rowscarried a second level ofadditional_properties, so a scalar cell value could not be represented in either direction:That left
get_sheet_data,query_sheet_data,query_namespace_data,insert_sheet_dataandupdate_sheet_dataworking only while the sheet was empty. The cells are free-form JSON, matching theMap<String, Object>andList<List<Object>>the API serves, so these models now carry a single level ofadditional_propertieslikeSample.metadata. The models are the generator's own output for the three corrected schemas; the rest of the spec is untouched to keep this off a full sync.CirroBio/Cirro-backend#854 fixes
RowInsertandRowUpdateat the source.SheetQueryResponse.rowscannot be fixed there — the cell sits two levels down inList<List<Object>>and micronaut-openapi has no annotation that reaches it — so the next schema sync will reintroduce the nested model forrowsuntil the DTO signature changes.Associated https://github.com/CirroBio/Cirro-backend/pull/854
Fixes #29
🤖 Generated with Claude Code