Skip to content

[SDK] Stamp generated certificates with aware UTC datetimes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V2arK merged 1 commit into from
Sep 17, 2026
Merged

[SDK] Stamp generated certificates with aware UTC datetimes #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions centml/sdk/utils/client_certs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
from dataclasses import dataclass
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone

import click
from cryptography import x509
Expand Down Expand Up @@ -31,9 +31,9 @@ def generate_ca_client_triplet(service_name: str) -> CAClientCertTriplet:
.issuer_name(ca_subject)
.public_key(ca_private_key.public_key())
.serial_number(x509.random_serial_number())
.not_valid_before(datetime.utcnow())
.not_valid_before(datetime.now(timezone.utc))
# Certificate valid for 5 years (give or take leap years)
.not_valid_after(datetime.utcnow() + timedelta(days=365 * 5))
.not_valid_after(datetime.now(timezone.utc) + timedelta(days=365 * 5))
.add_extension(x509.BasicConstraints(ca=True, path_length=None), critical=True)
# We are using SHA384 as it's often paired with secpr384r1, ie
# the weak link isn't the hash algorithm.
Expand All @@ -53,9 +53,9 @@ def generate_ca_client_triplet(service_name: str) -> CAClientCertTriplet:
.issuer_name(ca_certificate.subject)
.public_key(client_private_key.public_key())
.serial_number(x509.random_serial_number())
.not_valid_before(datetime.utcnow())
.not_valid_before(datetime.now(timezone.utc))
# Certificate valid for 5 years (give or take leap years)
.not_valid_after(datetime.utcnow() + timedelta(days=365 * 5))
.not_valid_after(datetime.now(timezone.utc) + timedelta(days=365 * 5))
.add_extension(x509.BasicConstraints(ca=False, path_length=None), critical=True)
# We are using SHA384 as it's often paired with secpr384r1, ie
# the weak link isn't the hash algorithm.
Expand Down
Loading