Skip to content

FIREFLY-2157: Redact sensitive information from logs - #2058

Merged
loitly merged 4 commits into
devfrom
FIREFLY-2157-redact-values-from-logs
Nov 2, 2026
Merged

loitly merged 4 commits into
devfrom
FIREFLY-2157-redact-values-from-logs

Conversation

@loitly

@loitly loitly commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-2157

Some logging paths printed credentials in full. All logged request/response headers now go through HttpServices.sanitizeHeader().

Fixed leaks:

  • ConcurrentDownload request headers and the HttpServices failure CURL CMD now go through sanitizeHeader().
  • AuthHeader also redacts schemeless Authorization, Proxy-Authorization, X-Api-Key, Api-Key, X-Auth-Token.
  • HttpServicesTest runs against a local HTTP server instead of httpbin, plus a test that the failure log has no token.

Test: https://firefly-2157-redact-values-from-logs.irsakubedev.ipac.caltech.edu/suit/

  • Upload a table from URL https://data-int.lsst.cloud/test/abc (404).
  • kubectl logs -n irsa-dev deploy/firefly-2157-redact-values-from-logs-suit -c suit | grep -A1 "test/abc"
  • Expect headers sent: Authorization: Bearer [redacted], ...

@loitly loitly added this to the 2026.4 milestone Oct 30, 2026
@loitly
loitly requested a review from aventura121 October 30, 2026 23:34
@loitly loitly self-assigned this Oct 30, 2026
@loitly loitly added the bug label Oct 30, 2026

@aventura121 aventura121 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi loi, looks good in general. A couple of things deferred to you on how to address.

  • Claude found the unguarded sanitizeHeader calls in URLDownload.java will throw and break the standalone app's ability to auto-update. (java.lang.NoClassDefFoundError).
  • Also, it looks like cookies can still leak if there's a failed request, if you want to take a look. Not a blocker for this change but may be worth adding while you're here, up to you.

@loitly

loitly commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@aventura121 Thanks for the review. I was on the fence about the cookie changes, but I went ahead and incorporated your suggestions. I also found an issue with the Job Monitor's Control column width that affected suit and fixed it in this PR.

@loitly
loitly merged commit 71c97fc into dev Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants