Repository navigation
FIREFLY-2157: Redact sensitive information from logs - #2058
Merged
Merged
Conversation
aventura121
approved these changes
Oct 31, 2026
Contributor
There was a problem hiding this comment.
Hi loi, looks good in general. A couple of things deferred to you on how to address.
- Claude found the unguarded sanitizeHeader calls in URLDownload.java will throw and break the standalone app's ability to auto-update. (java.lang.NoClassDefFoundError).
- Also, it looks like cookies can still leak if there's a failed request, if you want to take a look. Not a blocker for this change but may be worth adding while you're here, up to you.
Contributor
Author
|
@aventura121 Thanks for the review. I was on the fence about the cookie changes, but I went ahead and incorporated your suggestions. I also found an issue with the Job Monitor's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-2157
Some logging paths printed credentials in full. All logged request/response headers now go through
HttpServices.sanitizeHeader().Fixed leaks:
ConcurrentDownloadrequest headers and theHttpServicesfailureCURL CMDnow go throughsanitizeHeader().AuthHeaderalso redacts schemelessAuthorization,Proxy-Authorization,X-Api-Key,Api-Key,X-Auth-Token.HttpServicesTestruns against a local HTTP server instead of httpbin, plus a test that the failure log has no token.Test: https://firefly-2157-redact-values-from-logs.irsakubedev.ipac.caltech.edu/suit/
https://data-int.lsst.cloud/test/abc(404).kubectl logs -n irsa-dev deploy/firefly-2157-redact-values-from-logs-suit -c suit | grep -A1 "test/abc"headers sent: Authorization: Bearer [redacted], ...