Skip to content

fix(upgrade): tombstone .travis.yml so upgrades remove it - #880

Merged
TheWitness merged 1 commit into
developfrom
fix/manifest-tombstone-travis-877
Nov 20, 2026
Merged

TheWitness merged 1 commit into
developfrom
fix/manifest-tombstone-travis-877

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Ref #877

1.8.2 and earlier shipped .travis.yml at the plugin root. It isn't in manifest.json, so on upgrade thold_prune_files() logs thold upgrade found a file/directory not described in manifest.json: .travis.yml (left in place) and keeps it. This adds it to tombstones so the upgrade removes it.

This doesn't change when the prune runs. It still runs only when the INFO version changes, which is the other gap described in #877.

Testing:

  • Docker, Cacti 1.2.32, PHP 8.5.12, MariaDB 11.8: installed thold 1.8.2, copied this branch over it without deleting anything, and opened Thresholds. The upgrade removed .travis.yml along with the existing tombstones, and the unknown-file warning no longer appears.
  • php tests/bin/validate-manifest.php passes.
  • Pest against core develop: the prune tests pass (7 passed, 1 skipped). The full suite has 2 failures (NotificationQueueClaimTest, TholdGetCurrentvalTest) that fail identically on develop without this change.

1.8.2 and earlier shipped .travis.yml at the plugin root. It is not in
manifest.json, so thold_prune_files() logs it as an unknown entry and
leaves it in place on every upgrade. List it under tombstones so the
upgrade removes it.

Ref #877

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit c83262d into develop Nov 20, 2026
7 checks passed
@TheWitness
TheWitness deleted the fix/manifest-tombstone-travis-877 branch November 20, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants