Repository navigation
fix(upgrade): tombstone .travis.yml so upgrades remove it - #880
Merged
Merged
Conversation
1.8.2 and earlier shipped .travis.yml at the plugin root. It is not in manifest.json, so thold_prune_files() logs it as an unknown entry and leaves it in place on every upgrade. List it under tombstones so the upgrade removes it. Ref #877 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
TheWitness
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Ref #877
1.8.2 and earlier shipped
.travis.ymlat the plugin root. It isn't inmanifest.json, so on upgradethold_prune_files()logsthold upgrade found a file/directory not described in manifest.json: .travis.yml (left in place)and keeps it. This adds it totombstonesso the upgrade removes it.This doesn't change when the prune runs. It still runs only when the INFO version changes, which is the other gap described in #877.
Testing:
.travis.ymlalong with the existing tombstones, and the unknown-file warning no longer appears.php tests/bin/validate-manifest.phppasses.NotificationQueueClaimTest,TholdGetCurrentvalTest) that fail identically on develop without this change.