Repository navigation
hardening: escape the template filter name and skip RRD paths rrdtool would split - #879
Merged
Merged
Conversation
xmacan
previously approved these changes
Nov 19, 2026
Escape the data template name in the Associated Thresholds filter, and skip data sources whose RRD file name contains whitespace or quote characters instead of passing the path to rrdtool. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/output-escaping-and-rrd-paths
branch
from
November 19, 2026 09:04
5f0f38a to
f290186
Compare
|
TheWitness
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



notify_lists.php: escape the data template name in the Template filter options.includes/functions.php: newthold_rrd_path_is_safe().thold_get_rrd_statistics()returns false, andthold_rrd_last()returns an empty timestamp (already handled as "not polled yet"), when the RRD file name holds whitespace or quote characters. A space only in a directory name behaves as before.Tests:
tests/Unit/OutputEscapingAndRrdPathTest.php(12 passing). In the full suite one test fails,TholdCommandExecutionTest(exit 127), and it fails the same way ondevelop. Not run against a live Cacti or rrdtool.Fixes #878