Repository navigation
bug: Tombstone the replaced cli/updatedb_convert_ms.php - #474
Merged
Merged
Conversation
#471 replaced cli/updatedb_convert_ms.php with cli/upgrade_partitioning.php --convert-ms but did not tombstone it, so installs upgraded from the #449 build keep the old script. It truncates the message tables and ALTERs logtime to TIMESTAMP(3) in place, which fails on legacy TO_DAYS(logtime) partitioned tables with "Constant, random or timezone-dependent expressions in (sub)partitioning function are not allowed". Add it to manifest.json tombstones so syslog_prune_files() removes it on upgrade, and point the 5.0 release notes at the replacement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the obsolete-converter cleanup and updated migration guidance.
No open issues 🎉
What changed in this PR
Completes the cleanup from #471 by marking the obsolete, destructive timestamp converter for removal and directing users to the safer replacement.
Changes:
- Adds
cli/updatedb_convert_ms.phpto the tombstones for removal on the next version-triggered upgrade. - Updates release notes to describe the preserving conversion command, explicit data-discard option, and legacy
DATETIMElimitation. - Records the cleanup in the develop changelog.
| File | Description |
|---|---|
manifest.json |
Marks the obsolete converter for upgrade-time removal. |
docs/RELEASE_NOTES_5.0.md |
Replaces outdated conversion guidance with the supported command and its limitations. |
CHANGELOG.md |
Documents the tombstone and replacement command. |
Review effort: Balanced
bmfmancini
approved these changes
Nov 20, 2026
bmfmancini
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
#471 replaced
cli/updatedb_convert_ms.phpwithcli/upgrade_partitioning.php --convert-msbut did not tombstone the old file. Installs upgraded from the #449 build therefore keep the old script, and the 5.0 release notes still told users to run it.The old script truncates
syslog,syslog_incomingandsyslog_removed, then runsALTER ... MODIFY COLUMN logtime timestamp(3)in place. On a legacy table partitioned byRANGE (TO_DAYS(logtime))over aDATETIMEcolumn, that fails:This was reported on MariaDB 11.4.12, but it is not tied to that version:
TO_DAYS()over aTIMESTAMPcolumn is rejected on any MariaDB or MySQL version. By the time of the error, the tables had already been truncated.Changes
manifest.json: addcli/updatedb_convert_ms.phptotombstones, sosyslog_prune_files()removes it on upgrade.docs/RELEASE_NOTES_5.0.md: describecli/upgrade_partitioning.php --convert-ms(data preserved by default,--discard-data, legacyDATETIMElimitation) and note that the old utility is replaced and removed.CHANGELOG.md: entry under develop.Validation
php tests/bin/validate-manifest.phppasses.syslog_prune_files()against a temporary plugin tree using the new manifest:cli/updatedb_convert_ms.phpwas removed,cli/upgrade_partitioning.phpwas kept, and nothing was logged.The prune runs only when the plugin version changes, so the file is removed at the next version bump.