Repository navigation
fix(setup): correct reportsit.php typo and drop charts.php entries - #160
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…se formatting Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
xmacan
previously approved these changes
Nov 19, 2026
|
xmacan
approved these changes
Nov 19, 2026
TheWitness
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
reportsit.phptypo withreportit.phpin the navigation entries (keys, urls, mappings) and in the General Administration role augmentation. The role entry never matched a registered realm before, so that role now receives the Create Reports realm as intended.charts.php(registration, Normal User role, upgrade step) and its three navigation entries; nocharts.phpexists in the plugin and there is no equivalent page to point at.Related Issue
N/A
Motivation and Context
The typo and the dead page reference made the breadcrumbs and role grants refer to files that do not exist. Cacti's
auth_augment_roles()matches realms by comma-list element, soview.phpstill matches existing installs whose stored realm isview.php,charts.php.How Has This Been Tested?
php -lon setup.php and system/upgrade.php; grep confirms no remainingcharts.phporreportsitreferences outside the CHANGELOG. Not exercised in a live Cacti.Types of changes