Skip to content

fix(setup): correct reportsit.php typo and drop charts.php entries - #160

Merged
TheWitness merged 6 commits into
developfrom
fix/realm-nav-entries
Nov 20, 2026
Merged

TheWitness merged 6 commits into
developfrom
fix/realm-nav-entries

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Description

  • Replace the reportsit.php typo with reportit.php in the navigation entries (keys, urls, mappings) and in the General Administration role augmentation. The role entry never matched a registered realm before, so that role now receives the Create Reports realm as intended.
  • Remove the realm file charts.php (registration, Normal User role, upgrade step) and its three navigation entries; no charts.php exists in the plugin and there is no equivalent page to point at.
  • Update the Copilot instructions snippet and add a CHANGELOG entry.

Related Issue

N/A

Motivation and Context

The typo and the dead page reference made the breadcrumbs and role grants refer to files that do not exist. Cacti's auth_augment_roles() matches realms by comma-list element, so view.php still matches existing installs whose stored realm is view.php,charts.php.

How Has This Been Tested?

php -l on setup.php and system/upgrade.php; grep confirms no remaining charts.php or reportsit references outside the CHANGELOG. Not exercised in a live Cacti.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…se formatting

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
xmacan
xmacan previously approved these changes Nov 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit f25cb71 into develop Nov 20, 2026
6 checks passed
@TheWitness
TheWitness deleted the fix/realm-nav-entries branch November 20, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants