Skip to content

ci: add non-blocking PHP 8.6 matrix leg - #157

Merged
TheWitness merged 3 commits into
developfrom
ci/add-php-8.5-8.6-matrix
Nov 8, 2026
Merged

TheWitness merged 3 commits into
developfrom
ci/add-php-8.5-8.6-matrix

Conversation

@TheWitness

Copy link
Copy Markdown
Member

What

Adds PHP 8.6 as a non-blocking (experimental) leg to the integration-test matrix, mirroring the method used in Cacti/cacti#8633.

This plugin already tests PHP 8.5 as a blocking matrix leg, so only 8.6 is added here.

How

  • Add continue-on-error: ${{ matrix.experimental }} to the job and experimental: [false] to the base matrix.
  • Add an include: leg for 8.6 with experimental: true.
  • 8.6 is still pre-release; the setup-php nightly ships ABI-skewed bundled extensions, so the 8.6 leg provisions a coherent CLI from Ondrej Sury's PPA instead.
  • The Ondrej PPA has no php8.6-xdebug build yet, so the patch-coverage gate is skipped on the 8.6 leg only.

Notes

  • The new leg is non-blocking, so required checks are unaffected.
  • Any genuine deprecation failures surfaced by the 8.6 leg are addressed in follow-up commits on this branch.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Mirror Cacti/cacti#8633. This plugin already tests PHP 8.5 as a blocking
matrix leg, so only PHP 8.6 is added here, as an experimental
(non-blocking) leg via continue-on-error.

PHP 8.6 is still pre-release and the setup-php nightly ships ABI-skewed
bundled extensions, so the 8.6 leg provisions a coherent CLI from Ondrej
Sury's PPA instead. The Ondrej PPA has no php8.6-xdebug build yet, so the
patch-coverage gate is skipped on the 8.6 leg only.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 7, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PHP 8.6 leg still requests coverage without a driver, triggering a fatal PHPUnit warning that fails CI and prevents subsequent linting and poller checks.

1 open issue
What changed in this PR

Adds experimental PHP 8.6 integration testing for the ReportIt plugin while keeping PHP 8.3–8.5 checks blocking.

Changes:

  • Adds a non-blocking PHP 8.6 matrix leg.
  • Provisions PHP 8.6 through Ondřej Surý’s PPA instead of setup-php.
  • Skips the patch-coverage gate on PHP 8.6 because no matching Xdebug build is available.
File Description
.github/​workflows/​plugin-ci-workflow.yml Adds the experimental PHP 8.6 leg, dedicated toolchain installation, and coverage-gate exclusion.

Review effort: Balanced

somethingwithproof and others added 2 commits November 7, 2026 18:59
Use the runner effective group alongside the www-data user so newly created RRD files match the existing CI directory ownership. Covers flat and structured RRD paths without changing directory modes or suppressing warnings.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
ubuntu-latest has rolled to Ubuntu 26.04 (Resolute). Ondrej Surys
Launchpad PPA (ppa:ondrej/php) has no Release file for the resolute
suite yet (it is migrating to packages.sury.org), so apt-get update
404s and the experimental 8.6 PPA toolchain install dies with exit
code 100.

Pin the experimental 8.6 leg to ubuntu-24.04 (Noble), which still
serves the latest packaged 8.6 release candidate from the PPA. The
other legs use shivammathur/setup-php and are unaffected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2026

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit 83e361f into develop Nov 8, 2026
6 checks passed
@TheWitness
TheWitness deleted the ci/add-php-8.5-8.6-matrix branch November 8, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants