Repository navigation
ci: add non-blocking PHP 8.6 matrix leg - #157
Merged
Merged
Conversation
Mirror Cacti/cacti#8633. This plugin already tests PHP 8.5 as a blocking matrix leg, so only PHP 8.6 is added here, as an experimental (non-blocking) leg via continue-on-error. PHP 8.6 is still pre-release and the setup-php nightly ships ABI-skewed bundled extensions, so the 8.6 leg provisions a coherent CLI from Ondrej Sury's PPA instead. The Ondrej PPA has no php8.6-xdebug build yet, so the patch-coverage gate is skipped on the 8.6 leg only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PHP 8.6 leg still requests coverage without a driver, triggering a fatal PHPUnit warning that fails CI and prevents subsequent linting and poller checks.
1 open issue
What changed in this PR
Adds experimental PHP 8.6 integration testing for the ReportIt plugin while keeping PHP 8.3–8.5 checks blocking.
Changes:
- Adds a non-blocking PHP 8.6 matrix leg.
- Provisions PHP 8.6 through Ondřej Surý’s PPA instead of setup-php.
- Skips the patch-coverage gate on PHP 8.6 because no matching Xdebug build is available.
| File | Description |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adds the experimental PHP 8.6 leg, dedicated toolchain installation, and coverage-gate exclusion. |
Review effort: Balanced
Use the runner effective group alongside the www-data user so newly created RRD files match the existing CI directory ownership. Covers flat and structured RRD paths without changing directory modes or suppressing warnings. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
ubuntu-latest has rolled to Ubuntu 26.04 (Resolute). Ondrej Surys Launchpad PPA (ppa:ondrej/php) has no Release file for the resolute suite yet (it is migrating to packages.sury.org), so apt-get update 404s and the experimental 8.6 PPA toolchain install dies with exit code 100. Pin the experimental 8.6 leg to ubuntu-24.04 (Noble), which still serves the latest packaged 8.6 release candidate from the PPA. The other legs use shivammathur/setup-php and are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
xmacan
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What
Adds PHP 8.6 as a non-blocking (experimental) leg to the integration-test matrix, mirroring the method used in Cacti/cacti#8633.
This plugin already tests PHP 8.5 as a blocking matrix leg, so only 8.6 is added here.
How
continue-on-error: ${{ matrix.experimental }}to the job andexperimental: [false]to the base matrix.include:leg for8.6withexperimental: true.php8.6-xdebugbuild yet, so the patch-coverage gate is skipped on the 8.6 leg only.Notes
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com