Repository navigation
Partitioning: Include 802.1x history - #461
Merged
Merged
Conversation
Apply the existing scan-date partition lifecycle to 802.1x history while retaining the port retention setting and supporting interrupted upgrades. Bump the plugin version to 5.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new 802.1x history rebuilds and partition-dropping retention lack live MySQL/MariaDB validation of row preservation, retention behavior, and interrupted-rebuild recovery.
No open issues 🎉
What changed in this PR
Extends the Cacti Device Tracking plugin’s existing history partitioning to include 802.1x events alongside MAC and IP address history.
Changes:
- Includes
mac_track_dot1xin fresh-install partitioning, maintenance, rebuilds, and status reporting while preserving the existing port-retention setting. - Expands regression coverage and updates maintenance notices, documentation, and translation strings.
- Bumps the plugin version to 5.1 and records the change.
| File | Description |
|---|---|
tests/Unit/PartitionRebuildTest.php |
Covers 802.1x installation, rebuilds, interruption detection, retention, and notices. |
tests/Unit/PartitionMaintainTest.php |
Tests 802.1x partition maintenance and unpartitioned retention behavior. |
tests/Unit/ArpDot1xRetentionTest.php |
Updates the assertion for the retention-deletion fallback. |
setup.php |
Clarifies that the partition-size setting includes 802.1x. |
README.md |
Documents partitioning and rebuild behavior for all three history tables. |
mactrack_view_dot1x.php |
Displays the partition-rebuild maintenance notice. |
mactrack_utilities.php |
Adds 802.1x partition status and updates utility descriptions. |
locales/po/cacti.pot |
Refreshes translation strings for the expanded partitioning scope. |
lib/mactrack_partitions.php |
Registers 802.1x history in the shared partition-table list. |
lib/mactrack_partition_rebuild.php |
Updates shared rebuild messages and documentation. |
lib/mactrack_partition_ops.php |
Records separate 802.1x partition-maintenance status. |
lib/mactrack_functions.php |
Adds partition-aware 802.1x retention and updates rebuild confirmation text. |
lib/mactrack_activity.php |
Includes 802.1x in partitioning activity messages. |
INFO |
Changes the plugin version from 5.0 to 5.1. |
includes/database.php |
Partitions newly created 802.1x history tables. |
cli/upgrade_partitioning.php |
Updates CLI help, warnings, and comments to include 802.1x. |
CHANGELOG.md |
Records the 802.1x partitioning fix. |
Review effort: Balanced
Remove the repeated install-time partition initialization and preserve the rule that existing history tables are never repartitioned by setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover both history tables with finite and unlimited port retention without duplicating maintenance scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
bmfmancini
approved these changes
Nov 18, 2026
xmacan
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Partition
mac_track_dot1xon fresh installs and include it in partition maintenance, status andupgrade_partitioning.phprebuilds. Preserve the existing port retention setting and bump INFO to 5.1.Related Issue
User-requested fix; no matching open issue identified.
Motivation and Context
802.1x history was left unpartitioned and omitted from rebuilds, unlike port and IP history. Existing installations can rebuild it with the partitioning utility or CLI.
How Has This Been Tested?
Screenshots (if appropriate):
Not applicable.
Types of changes
Checklist:
The plugin README was updated; no separate documentation repository was changed.