Skip to content

Reject non-finite UPS dashboard metrics - #67

Merged
TheWitness merged 1 commit into
developfrom
fix/reject-non-finite-dashboard-metrics
Nov 11, 2026
Merged

TheWitness merged 1 commit into
developfrom
fix/reject-non-finite-dashboard-metrics

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Reject non-finite RRD samples and estimated watts so invalid values cannot contaminate UPS dashboard aggregates and charts.

  • Filters non-finite RRD values and rejects non-finite or overflowing watt estimates.
  • Adds dashboard.php to the existing Clover source list so changed-line coverage measures it.
  • Adds regression tests for NaN, infinity, and overflow.

Fixes #66

Validation: 238 tests passed; 1 warning came from a localhost connection attempt blocked by the sandbox. The focused suites passed 39 tests (141 assertions), and changed-line coverage passed at 100% (6/6). PHP syntax and manifest validation passed. Live socket cases were excluded from the final broad run.

@somethingwithproof
somethingwithproof force-pushed the fix/reject-non-finite-dashboard-metrics branch from 61c1753 to ebf0a00 Compare November 9, 2026 01:42
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@somethingwithproof
somethingwithproof force-pushed the fix/reject-non-finite-dashboard-metrics branch from ebf0a00 to 73a730b Compare November 11, 2026 22:59
@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit aa7cada into develop Nov 11, 2026
7 checks passed
@TheWitness
TheWitness deleted the fix/reject-non-finite-dashboard-metrics branch November 11, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject non-finite UPS dashboard readings

2 participants