Skip to content

fix: 커스텀 템플릿 mutation 응답에서 삭제된 슬롯 제외 - #488

Merged
chanwoo7 merged 1 commit into
developfrom
fix/custom-template-deleted-slots
Oct 4, 2026
Merged

chanwoo7 merged 1 commit into
developfrom
fix/custom-template-deleted-slots

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Oct 4, 2026

Copy link
Copy Markdown
Member

배경

  • 이슈 #448입니다. 판매자 커스텀 템플릿의 두 뮤테이션(upsertProductCustomTemplate·setCustomTemplateActive) 응답에 삭제된 문구 슬롯이 섞여 나왔습니다.
  • nested include는 soft-delete Extension 밖인데, 같은 파일의 text_tokens include 6곳 중 이 두 곳에만 where: activeWhere가 없었습니다.

변경

  • 두 include에 where: activeWhere를 추가했습니다.

테스트

  • 삭제된 슬롯이 있는 템플릿에서 두 뮤테이션 응답의 textTokens가 살아 있는 슬롯만 담는지 확인하는 2건을 추가했습니다.
    • 수정을 되돌리면 2건 모두 삭제된 슬롯 id가 섞여 실패하는 것을 확인했습니다.

플랜 대조

플랜 2번 불릿 상태
두 include에 where: activeWhere 한 것
회귀: 슬롯 삭제 뒤 두 뮤테이션 응답에 그 슬롯이 없음 한 것

- nested include는 soft-delete Extension 밖인데 upsertProductCustomTemplate·setCustomTemplateActive 응답 include의 text_tokens에만 where가 없어, 판매자가 지운 슬롯이 두 mutation 응답에 다시 섞임(같은 파일의 나머지 text_tokens include 4곳은 activeWhere 명시)
- 두 include에 where: activeWhere 추가
- 회귀: 삭제 슬롯이 있는 템플릿에서 두 mutation 응답 textTokens가 활성 슬롯만 2건(수정 전 삭제 슬롯 id가 섞여 2건 모두 실패 확인)
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: CaQuick/caquick-be/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ebf17396-1d88-4e75-a68f-6372f43f23c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

Unused exported types (1)
전체 리포트
Unused exported types (1)
RateLimitPolicy  type  src/global/rate-limit/index.ts:4:8

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 470건 (error 12).

Category error warning info
architecture 1 1 42
correctness 0 261 0
performance 0 30 28
schema 0 0 75
security 11 21 0
architecture / security 상위 항목
  • error architecture/architecture/no-manual-instantiation: Manual instantiation of 'OutboxRepository' detected. Use dependency injection instead.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'getJwks' has no @UseGuards() at class or method level.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 97.91% 10044/10258
🟢 Branches 92.41% 3785/4096
🟢 Functions 97.44% 2021/2074
🟢 Lines 98.51% 9138/9276

Test suite run success

3729 tests passing in 355 suites.

Report generated by 🧪jest coverage report action from 6856e76

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chanwoo7
chanwoo7 merged commit 7bece88 into develop Oct 4, 2026
13 checks passed
@chanwoo7
chanwoo7 deleted the fix/custom-template-deleted-slots branch October 4, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant