fix: 다크 모드 보조 텍스트를 muted·secondary·accent 면에서도 AA 대비가 나오게 밝힘 - #64
Merged
Merged
Conversation
- 다크 --muted-foreground #85859a가 muted·secondary(#26262f) 위에서 4.15:1, accent·surface-tint(#201f2c) 위에서 4.50:1 미만(4.498)이라 본문 크기 기준 AA 4.5:1 미달. 대비 spec은 다크 background·card만 보고 있어 놓침 - 색상·채도(OKLCH C 0.031, H 285.5)는 그대로 두고 명도만 올려, 다크 면 전부에서 4.6:1 이상이 되는 가장 어두운 값 #8d8da2로 변경 - background 5.65, card·popover 5.21, muted·secondary 4.62, accent·surface-tint 5.00, sidebar 5.49 - foreground(#f0f0f4)와는 2.86:1로 여전히 한 단계 흐린 보조 텍스트 - 대비 spec에 다크 popover·muted·secondary·accent·surface-tint·sidebar 6행 추가(이전 색으로 되돌리면 muted·secondary·accent·surface-tint 4행 실패 확인)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File CoverageNo changed files found. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
--muted-foreground #85859a)가 muted·secondary 면(#26262f) 위에서 4.15:1로 WCAG AA(4.5:1)에 못 미쳤습니다.변경
다크
--muted-foreground를#8d8da2로 올렸습니다. 색상(OKLCH H 285.5)과 채도는 그대로 두고 밝기만 올렸습니다.#f0f0f4)와의 대비는 2.86:1로, 여전히 한 단계 흐린 보조 텍스트로 읽힙니다.대비 검사 표에 다크 popover·muted·secondary·accent·surface-tint·sidebar를 추가했습니다.
테스트
플랜 대조