Skip to content

chore: 릴리즈 — 검색 칩 spec 시간 초과 수정(검색 칩 화면 배포) - #61

Closed
chanwoo7 wants to merge 3 commits into
mainfrom
develop
Closed

chanwoo7 wants to merge 3 commits into
mainfrom
develop

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Oct 4, 2026

Copy link
Copy Markdown
Member

#60 릴리즈입니다. 직전 릴리즈 #59(검색 칩 관리 화면)는 main CI에서 테스트 1건이 5초 제한을 넘겨 실패해 이미지 빌드·운영 배포가 건너뛰어졌습니다. 그 테스트를 고친 #60을 포함해 다시 배포합니다.

머지 뒤 develop을 재생성합니다.

- main CI·로컬 전체 실행에서 드래그 흐름 테스트가 5초 제한 초과(5.3~5.6초)로 실패 → 이미지 빌드·배포가 건너뛰어짐
- 계측(단독): rowOf = getByRole('cell', { name }) 13회가 578ms(회당 약 44ms, 모든 셀의 접근 가능한 이름 계산), 버튼 aria-label 조회는 회당 약 12ms
- rowOf를 손잡이 버튼에서 행을 잡게, 표 대기 10곳도 손잡이 이름으로(tableReady) → 드래그 테스트 단독 1152 → 680ms, 전체 실행 부하 5.6초 → 3.2초
test: 검색 칩 spec의 셀 이름 조회를 손잡이 조회로 바꿔 전체 실행 시간 초과 해소
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: CaQuick/caquick-admin-fe/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4748909c-cd85-41a1-8008-e04d2e3a67a5
📥 Commits

Reviewing files that changed from the base of the PR and between 39d0155 and 5cb577c.

⛔ Files ignored due to path filters (1)
  • schema/schema.graphql is excluded by !schema/schema.graphql
📒 Files selected for processing (1)
  • src/features/search-chips/pages/search-chips.spec.tsx
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chanwoo7

chanwoo7 commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

보류: 테스트 성능 문제를 계측 기반으로 먼저 조사한 뒤 다시 릴리즈

@chanwoo7 chanwoo7 closed this Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 96.06% (🎯 80%) 2442 / 2542
🟢 Statements 95.53% (🎯 80%) 2675 / 2800
🟢 Functions 94.27% (🎯 80%) 1005 / 1066
🟢 Branches 88.06% (🎯 70%) 2014 / 2287
File CoverageNo changed files found.
Generated in workflow #122 for commit 5cb577c by the Vitest Coverage Report Action

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant