Skip to content

Fix Broken CI Tests - #28

Merged
i-am-sijia merged 7 commits into
CTPSSTAFF:mainfrom
wsp-sag:merge-fixes
Sep 30, 2026
Merged

i-am-sijia merged 7 commits into
CTPSSTAFF:mainfrom
wsp-sag:merge-fixes

Conversation

@i-am-sijia

@i-am-sijia i-am-sijia commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

This pull request updates the model execution environment, improves extension handling, and updates test and baseline data to reflect changes in the model structure and outputs. The most important changes are grouped below.

Model execution and extension handling

  • The model is now always executed from the model directory, and the --project .. flag is used to ensure correct path resolution for configs and data. This change is reflected in both the documentation (docs/execution-backends.md) and the model CI script (scripts/model_ci.py).
  • Extension handling is improved: the code now explicitly requires the model/extensions directory to exist and consistently uses this path for extension discovery and tracking.

Baseline and test updates

  • Baseline outputs in tests/baselines/10000.json and tests/baselines/2000.json are updated to reflect changes in model outputs, including new counts and distributions for persons, tours, trips, and mode shares. Notably, the mode RIDEHAIL is replaced by RIDESOURCE in these outputs.
  • The test import path for extensions is updated to use the model subdirectory, ensuring tests import from the correct location.
  • A test assertion is updated to check for the new mode name RIDESOURCE instead of RIDEHAIL, matching the model output changes.

@i-am-sijia i-am-sijia changed the title Fix things that got corrupted Fix Broken CI Tests Sep 30, 2026
@i-am-sijia
i-am-sijia requested a balanced review from Copilot September 30, 2026 02:47
@i-am-sijia
i-am-sijia marked this pull request as ready for review September 30, 2026 02:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Extension provenance hashing and documented backend commands still reference the obsolete root-level extension location.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Fixes extension loading and modernizes ActivitySim progress monitoring.

Changes:

  • Corrects walk-ability test imports and mode naming.
  • Derives monitoring state from resolved run plans and incremental logs.
  • Runs CI from model so extensions load correctly.
File Description
tests/​test_walk_ability.py Fixes extension path and RIDESOURCE assertion.
src/​lighthouse/​sys_monitor.py Adds dynamic run-plan and log-based monitoring.
scripts/​model_ci.py Corrects CI extension loading and working directory.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/model_ci.py
Comment thread scripts/model_ci.py
@i-am-sijia

Copy link
Copy Markdown
Collaborator Author

@mmilkovits, I updated the baseline distributions in the test folder: tests/baselines/10000.json and tests/baselines/2000.json, corresponding to the "broader" (10,000-household) and "model" (2,000-household) CI tests.

When CI runs these tests, it compares the generated output distributions against the baseline distributions. Differences are reported for review but do not result in test failures.

I ran the following command locally to regenerate and replace the two baseline distribution files.

uv run --locked python scripts/model_ci.py --households 2000 --sharrow off --output model/output_ci_off
uv run --locked python scripts/model_ci.py --households 10000 --sharrow off --output model/output_ci_off

@i-am-sijia
i-am-sijia merged commit d30d49f into CTPSSTAFF:main Sep 30, 2026
3 checks passed
@i-am-sijia
i-am-sijia deleted the merge-fixes branch September 30, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants