Repository navigation
fix(generation): wait up to 30 minutes for a lost generation to save - #185
Merged
Merged
Conversation
A film too long for one model response is now written in parts on the backend and can take about twenty minutes. The 10-minute fallback wait could give up and report a failure while the backend was still working. Matches the backend's RUN_LEASE_TTL_MS.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Backend PR COPPSARY/Motify-Backend#80 makes the agent write films that are too long for one model response (e.g. remaking 6–7 attached slides) in parts instead of failing. Those runs can take ~20 minutes.
BACKGROUND_WAIT_MS— the fallback that waits for a saved film after the editor loses track of a job (connection drop, backend restart) — was 10 minutes, so it could give up and show a failure while the backend was still finishing. Raised to 30 minutes to match the backend'sRUN_LEASE_TTL_MS.Job polling in
runMotionMessagehas no overall deadline, andMAX_PROMPT_IMAGESis already 10 to match the backend, so nothing else changes.Testing
tests/ui/background-generation.test.tsandsrc/cloud/projects-api.test.tspass (27 tests).