Repository navigation
feat: move the voice over control to the top of the composer and gate it in proudction - #184
Merged
Merged
Conversation
… it in production The voice over switch is now a dropdown (On, Off, Customize voice) styled like the Brand DNA chip. Production builds (VITE_DD_ENV prod) open a coming-soon card instead and never request voice generation.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voice over direction: ….VITE_DD_ENVisprodorproduction) don't show the dropdown. Clicking Voice over opens a "Coming soon" card, styled like the "We're still early" notice and rendered ondocument.bodyso it centers over the whole page.ttsis always sent asfalseand the voice direction isn't added to the prompt. This goes through a new shared helper,isVoiceOverReleased(), used by both the panel andApp.svelte. Before this, the toggle defaulted to on, so production requests still asked for a voice over.ttstype additions indirect-ai.tsandgeneration-guidance.ts, and the "Untitled Motionly Project" to "Untitled Motify Project" rename.Testing
npx svelte-check: 0 errors, 0 warnings.npx vitest run src/ui/cloud/TiffyPanel.test.ts: 24 of 24 pass. This covers the On/Off/Customize dropdown, the production coming-soon card (opens, sits outside the composer, closes with "Got it"), and the no-toggle case for local projects.npm test.ttsisfalsein the generation request in production. I checked that by reading the code, and no other place insrc/setstts.Visual Evidence
Risk
VITE_DD_ENVbeing exactlyprodorproduction. Any other value gets the full dropdown and can request a voice over.ttson/off flag, so there's no real voice selection yet..envsetsVITE_DD_ENV=prodsee the coming-soon card and needdevto test the dropdown.Checklist
npm test.