Skip to content

Fixed linear regression estimator for categorical treatments - #418

Merged
jmafoster1 merged 1 commit into
mainfrom
jmafoster1/fix-linear-regression
Oct 14, 2026
Merged

jmafoster1 merged 1 commit into
mainfrom
jmafoster1/fix-linear-regression

Conversation

@jmafoster1

@jmafoster1 jmafoster1 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes LinearRegressionEstimator class to work for categorical treatments.

Checklist

Before you mark your PR as ready for review, please ensure you have completed the following.

  • Added unit tests for new functionality
  • Properly documented any new code
  • Updated Sphinx documentation in docs/ and checked for updated configuration/runtime options
  • Added a jupyter notebook tutorial in docs/source/tutorials for any new functionality
  • Verified local docs build with sphinx-build -W source/ build

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ PYTHON black 32 1 0.98s
✅ PYTHON pylint 32 0 5.01s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (78e0c66) to head (b7c8e1e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   98.26%   98.06%   -0.20%     
==========================================
  Files          26       26              
  Lines        1612     1605       -7     
==========================================
- Hits         1584     1574      -10     
- Misses         28       31       +3     
Files with missing lines Coverage Δ
..._testing/estimation/linear_regression_estimator.py 93.75% <100.00%> (-6.25%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d945198...b7c8e1e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmafoster1

Copy link
Copy Markdown
Collaborator Author

Ah, classic codecov getting confused when code goes away!

@jmafoster1

Copy link
Copy Markdown
Collaborator Author

@jwhogg no rush on this - I'm OOO tomorrow. I set the experiment running on this version in editable mode just to see what happens.

@jmafoster1
jmafoster1 requested a review from jwhogg October 8, 2026 16:08
@jmafoster1
jmafoster1 marked this pull request as ready for review October 8, 2026 16:09

@jwhogg jwhogg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmafoster1
jmafoster1 merged commit 373a413 into main Oct 14, 2026
26 of 29 checks passed
@jmafoster1
jmafoster1 deleted the jmafoster1/fix-linear-regression branch October 14, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants