Skip to content

Added the option for an initial individual - #408

Merged
jmafoster1 merged 8 commits into
mainfrom
jmafoster1/modular-discovery
Oct 8, 2026
Merged

jmafoster1 merged 8 commits into
mainfrom
jmafoster1/modular-discovery

Conversation

@jmafoster1

@jmafoster1 jmafoster1 commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Added the ability to specify an initial individual for HillClimberDiscovery, e.g. from a different causal discovery technique. I also moved max_iterations into the function arguments rather than the class object.

Checklist

Before you mark your PR as ready for review, please ensure you have completed the following.

  • Added unit tests for new functionality
  • Properly documented any new code
  • Updated Sphinx documentation in docs/ and checked for updated configuration/runtime options
  • Added a jupyter notebook tutorial in docs/source/tutorials for any new functionality
  • Verified local docs build with sphinx-build -W source/ build

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ PYTHON black 32 1 0.74s
✅ PYTHON pylint 32 0 4.7s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.26%. Comparing base (1c8eaf1) to head (78e0c66).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   98.57%   98.26%   -0.32%     
==========================================
  Files          26       26              
  Lines        1615     1612       -3     
==========================================
- Hits         1592     1584       -8     
- Misses         23       28       +5     
Files with missing lines Coverage Δ
causal_testing/discovery/hill_climber_discovery.py 90.19% <100.00%> (-9.81%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d63924...78e0c66. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmafoster1
jmafoster1 marked this pull request as ready for review September 6, 2026 08:29
@jmafoster1
jmafoster1 requested a review from jwhogg September 6, 2026 08:29
@jmafoster1

Copy link
Copy Markdown
Collaborator Author

So we were at 110% coverage before??
image

@jwhogg jwhogg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmafoster1
jmafoster1 merged commit d945198 into main Oct 8, 2026
16 of 17 checks passed
@jmafoster1
jmafoster1 deleted the jmafoster1/modular-discovery branch October 8, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants