Repository navigation
Jmafoster1/visualisation - #403
jmafoster1 wants to merge 56 commits into
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 35 | 1 | 1.11s | ||
| ✅ PYTHON | pylint | 35 | 0 | 6.34s |
See detailed report in MegaLinter reports
| raise ValueError(f"Test Value type {effect_estimate.type} is not valid for this CausalEffect") | ||
|
|
||
| return (~((effect_estimate.ci_low <= value_to_check) & (value_to_check <= effect_estimate.ci_high))).all() | ||
| return (~((effect_estimate.ci_low <= value_to_check) & (value_to_check <= effect_estimate.ci_high))).any() |
There was a problem hiding this comment.
Bug fix: This should have been .any() all along
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 98.06% 98.00% -0.07%
==========================================
Files 26 29 +3
Lines 1605 1901 +296
==========================================
+ Hits 1574 1863 +289
- Misses 31 38 +7
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…rk into jmafoster1/visualisation
191e5c4 to
d5b88a2
Compare
4d19b71 to
c3bf722
Compare
c3bf722 to
6be7948
Compare
|
Right, this should be fine now. Patch coverage is 100%, but Codecov sometimes gets confused when you move/delete code that was previously covered, which is what's happened here. |
|
TODO: Double check the kurtosis interpretation ("suspiciously stable"/"suspiciously unstable") before merging EDIT: I think it's fine as is |
…rk into jmafoster1/visualisation
This PR adds a visualisation dashboard to the CTF to serve as a nice pretty GUI. (Sorry it ended up being a bit of a monster PR!)
Closes #411
If you want to see the dashboard in action, check out this branch, install the dependencies to a virtual environment of your choice, and run
causal-testing dashboard. You can then navigate to https://localhost:5006 and "upload" use dag/data fromexamples.Main changes
abstract_discovery.pyand into a separate dedicated visualisation packageeffect_directionintoCausalTestResultclass. Ideally, this would be part ofEffectEstimate, but that leads to circular imports withCausalEffect:(EffectEstimate.valuetoEffectEstimate.effect_estimate(this touches a lot of files)