Skip to content

Allow community managers/owners access to EP requests #995

Closed

Description

@palkerecsenyi

Right now, only the user who requested the EP(/committee) approval and the EP referees have access to the request. Other users, e.g. the managers of the community, do not have access.

The submitter also does not have the permission to manually add reviewers.

Ideally, all members of the community who are able to submit an EP approval request (i.e. managers and owners) should be able to view the request, regardless of who originally submitted it.

There are two options:

  • Simply allow community managers/owners access to the request always.
  • Allow the submitter to manually add reviewers, via which they could grant access to managers/owners

The first solution is preferable in my opinion. Maybe it can be implemented by setting the community as the submitter rather than a specific user?

Activity

  1. changed the title [-]Allow community curators to access EP request[/-] [+]Allow community curators access to EP requests[/+] on Sep 29, 2026
  2. liptakpanna commented on Oct 7, 2026

    @liptakpanna
    Contributor

    I looked into this and I have some questions.

    The title of the issue says the community curators should be able to see this, but in the description only the managers and the owners are mentioned?

    Summary:

    Action Currently Goal
    Submit a request Community manager or community owner Community manager or community owner
    Read the request The user who sent the request + EP committee The user who sent the request + EP committee + community manager or community owner
    Read/write comments The user who sent the request + EP committee The user who sent the request + EP committee + community manager or community owner
    Cancel the request The user who sent the request The user who sent the request + community manager or community owner ?
    Approve/decline EP committee EP committee

    Then for the viewing of the request there are 2 ways:

    • From the record itself click on View request. This is straightforward: if user can read the request, this button should work
    • In My dashboard Requests. Here should it show up and if yes, on which tab? This might require a bigger change.
      • My requests: creator of the request is the user
      • Shared with me: the EP committee it is sent to

    Then who gets what notification is also a question:

    Event Currently Goal (suggested)
    Submitted EP committee EP committee + community manager or community owner
    Accepted Request sender (fails: no template) Request sender + community manager or community owner
    Declined Request sender (fails: no template) Request sender + community manager or community owner
    Cancelled Nobody Nobody

    Maybe it can be implemented by setting the community as the submitter rather than a specific user?

    If the community is the submitter then we lose the information which user has initiated the request and this could be important?

  3. palkerecsenyi commented on Oct 7, 2026

    @palkerecsenyi
    MemberAuthor

    The title of the issue says the community curators should be able to see this, but in the description only the managers and the owners are mentioned?

    Sorry, I named the issue wrong! Indeed this should only apply to managers and owners.

    Then for the viewing of the request there are 2 ways:

    The permission for the "View comments" button showing up on the request and whether the request shows up in your dashboard are (I think, could be wrong) based on the same permission. In my opinion it should show up in "My requests" if you are a manager/owner of the community the record is in and in "Shared with me" if you are an EP referee. Not sure what others think though!

    Then who gets what notification is also a question:

    I agree with your table, this looks good

    If the community is the submitter then we lose the information which user has initiated the request and this could be important?

    Hmmm I think if you implement the permissions as I described then we shouldn't need this information? I'm personally not sure if we explicitly need it, maybe we depend on it somewhere in the code. We also need to check with EP, but I don't think they need to know either. @zzacharo i am sure there was a reason we did it like this originally, do you remember?

  4. changed the title [-]Allow community curators access to EP requests[/-] [+]Allow community managers/owners access to EP requests[/+] on Oct 7, 2026
  5. liptakpanna commented on Oct 9, 2026

    @liptakpanna
    Contributor

    I created a PR (#1020) that allows managers and owners of the community to see EP approval requests - even if it wasn't initiated by them:

    • they can comment
    • they can cancel

    @zzacharo suggested to show these requests in the Community, Requests tab and that search query is set in invenio-communities (here). We can create a custom CommunityService and overwrite search_community_requests but then any upstream change to it has to be added manually..at least that's my understanding.

  6. liptakpanna commented on Oct 9, 2026

    @liptakpanna
    Contributor

    For the notifications: currently only on EP approval submit a mail is sent out to the referees.
    For accept and decline there is no jinja template for the mail, so it fails. Is this on purpose? Because the notification builder is there that is should go out to the submitter.
    This could be extended for all the manager/owners and the template could be added as part of this issue.

  7. liptakpanna commented on Oct 12, 2026

    @liptakpanna
    Contributor

    One more thing to note: for the Community requests it shows the View comments that points to the request, but for the EP approval once it's approved it shows only the link for the original record. Isn't the same link needed there to view the request?

    Because for now it would not show up in the managers/owners own dashboard, so it would be the only way to access the request.

  8. zzacharo commented on Oct 12, 2026

    @zzacharo
    Contributor

    14. One more thing to note: for the Community requests it shows the View comments that points to the request, but for the EP approval once it's approved it shows only the link for the original record. Isn't the same link needed there to view the request?
    From the original record, you have the EP section which describes the 3 steps and has a link to view the request.

     Because for now it would not show up in the managers/owners own dashboard, so it would be the only way to access the request.
    

    Does it show up under "My dashboard / Shared with me" ?

  9. liptakpanna commented on Oct 12, 2026

    @liptakpanna
    Contributor

    Does it show up under "My dashboard / Shared with me" ?

    No, because it's only creator or receiver (code) and receiver is based on role or id (code), not a community role like in our case. It is a possible extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions