Repository navigation
fix(hr): accept REPORT/BROCHURE scoped by 710 HR - #656
Merged
kpsherva merged 1 commit intoOct 20, 2026
Merged
Conversation
TahaKhan998
force-pushed
the
fix/hr-model-report-brochure
branch
from
October 19, 2026 09:06
ec12541 to
d63fc47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #623 some leftover hr records weren’t covered by the model because their 980 is just REPORT or BROCHURE. those tags are used all over cern so we only take them when 710 $5 is HR.
also had to map the resource types, allow the 690 collections they use (and the pulhr typo), put 020 $a isbns in related_identifiers so 2950074 doesn’t fail, and set role other when 710 is stored as a contributor since rdm requires a role there.