Skip to content

ci: fix eslint - #28

Open
liviaUeno wants to merge 6 commits into
developfrom
fix-eslint
Open

liviaUeno wants to merge 6 commits into
developfrom
fix-eslint

Conversation

@liviaUeno

Copy link
Copy Markdown

Summary

Reduces ESLint errors from 61 to 20 with changes that do not need a product or legal decision.

  • Apply ESLint auto-fixes (import order, redundant JSX braces, type-only imports, duplicate imports, JSX tag spacing). No behavior change.
  • Remove an unused _t import and add an explicit return type to useIsAdmin.
  • Read window size from UIStore instead of window.innerWidth/innerHeight (VodsDrawer, LiveStreamWidget), as required by no-restricted-properties.
  • Satisfy react-hooks/exhaustive-deps in the LiveStreamWidget HLS effect by depending on a local liveUrl, so the player is still recreated only when the URL changes.
  • Rename the destructured playback_url to playbackUrl in SecurityRoomSettingsTab (the API field is unchanged).

Still failing (not in this PR)

  • 20 × matrix-org/require-copyright-header on fork-created files: waiting for the header text to use.

Verification

pnpm -r lint:js: 61 → 20 errors, all require-copyright-header.

@liviaUeno
liviaUeno requested a review from zZMathSP October 22, 2026 13:52
@liviaUeno liviaUeno changed the title Fix eslint ci: fix eslint Oct 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant