Repository navigation
BI-2922: Study Cache 5 - Update bi-api to utilize prodserver for filtering/sorting/pagination - #497
Conversation
| method: 'get', | ||
| params: { | ||
| trialDbId: trialDbId, | ||
| pageSize: 65000 |
There was a problem hiding this comment.
Can we make this a variable instead of hardcoding it so it's reused, and make a comment about how 65k is the maximum page size for downstream usages of bi-api's BrAPIDAOUtil.simpleSearch(), which all user-facing features in bi-web should be using for filtered BrAPI entity search requests. That will make it feel less arbitrary.
There was a problem hiding this comment.
After some discussion, it would be best if we could utilize the environment variable CACHE_BRAPI_FETCH_PAGE_SIZE = 65000 and exists in the environment variables in production and pass it through as the page size.
I think to do this, you could try referencing this variable directly as process.env.CACHE_BRAPI_FETCH_PAGE_SIZE in the vue.config.js, and you can make the default value 65000.
If referencing the variable directly does not work, you may have to load it in a .env file in the bi-web repo itself.
There was a problem hiding this comment.
Modified the code as per the suggestions, please review again.
Description
Story: BI-2922
Modified the existing Max Page count to be 65000 instead of the current 100000 which exceeds the backend limit.
Also updated the lookup logic.
The Page behavior is not touched part of this change.
Dependencies
bi-web: feature/BI-2922
bi-api: feature/BI-2922
brapi-Java-ProdServer: feature/BI-2922
Testing
For end to end testing, we can use the Experiments & Observations page in the UI: The UI can verify the end-to-end Studies retrieval.
Checklist: