Skip to content

BI-2922: Study Cache 5 - Update bi-api to utilize prodserver for filtering/sorting/pagination - #497

Merged
jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2922
Sep 28, 2026
Merged

jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2922

Conversation

@humsika

@humsika humsika commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Story: BI-2922

Modified the existing Max Page count to be 65000 instead of the current 100000 which exceeds the backend limit.
Also updated the lookup logic.
The Page behavior is not touched part of this change.

Dependencies

bi-web: feature/BI-2922
bi-api: feature/BI-2922
brapi-Java-ProdServer: feature/BI-2922

Testing

For end to end testing, we can use the Experiments & Observations page in the UI: The UI can verify the end-to-end Studies retrieval.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

…nstead of the current 100000 which exceeds the backend limit. Also updated the lookup logic.
…5k records and removed the additional logic.
Comment thread src/breeding-insight/dao/StudyDAO.ts Outdated
method: 'get',
params: {
trialDbId: trialDbId,
pageSize: 65000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a variable instead of hardcoding it so it's reused, and make a comment about how 65k is the maximum page size for downstream usages of bi-api's BrAPIDAOUtil.simpleSearch(), which all user-facing features in bi-web should be using for filtered BrAPI entity search requests. That will make it feel less arbitrary.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, it would be best if we could utilize the environment variable CACHE_BRAPI_FETCH_PAGE_SIZE = 65000 and exists in the environment variables in production and pass it through as the page size.

I think to do this, you could try referencing this variable directly as process.env.CACHE_BRAPI_FETCH_PAGE_SIZE in the vue.config.js, and you can make the default value 65000.

If referencing the variable directly does not work, you may have to load it in a .env file in the bi-web repo itself.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the code as per the suggestions, please review again.

@jloux-brapi
jloux-brapi merged commit 140ab8f into epic/BI-2862 Sep 28, 2026
1 check passed
@jloux-brapi
jloux-brapi deleted the feature/BI-2922 branch September 28, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants