Repository navigation
Put the Human Inbox button in the Bot-mode row with tutorial progress and settings - #1630
Merged
Merged
Conversation
… and settings The wide Bot-mode row now holds one right-aligned action group: tutorial progress, Human Inbox and the settings gear. The inbox is no longer a bordered pill laid over the row from the panel list, so it no longer hides the tutorial ring or drops the row's hover when pointed at. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CugEyUiMxNL4Yvxg5gYRi4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CugEyUiMxNL4Yvxg5gYRi4
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
In the app sidebar's Bot-mode row, the Human Inbox button floated above the row as a bordered pill instead of sitting with the tutorial progress ring and the settings gear. It covered the tutorial ring, and pointing at it dropped the row's hover so the gear disappeared. Outside Bot mode it overlapped the "Try it" hint.
Issue / Discussion: none, reported in the project thread.
Special things to note
BotPanelIcon); revert the commit. Blast radius: only the wide Bot-mode row. The collapsed rail keeps its own inbox button in the panel list, unchanged. Review focus: the wide inbox is now aspan role="button"inside the native row<button>(same pattern as the gear and the tutorial launcher), and the row's capture-phase click guard now also skips.bh-panel-activity.--dsw-alias-interactive-bg-hoverhover, so the three controls read as one group. Nothing new is added to the design-token work in Move Bot-mode surfaces, mobile, the window companion and Computer/Browser settings onto design tokens #1626 and later; this only removes a border.packages/client/test/bot-panel-entry.test.tsupdated: the wide inbox lives in.bh-panel-actionsinside the row with the gear, Enter on it opens the inbox without leaving Bot mode, the narrow rail button stays in the panel list. Client Vitest: 1538 passed, 1 skipped;client-observer.test.tsfails the same way onmain(node:sqlitebundling).pnpm lint,pnpm format:check,pnpm typecheck,pnpm buildpass.scripts/e2e-activity-entry.mjs seed), screenshots frommain(7fe5079) and this branch at 1280×800, DPR 2.Change outline
Bot-mode row — 1280 × 800, 111 unread Human Inbox items
Before: the inbox pill sits above the row with a border and its own fill; on row hover it hides the tutorial ring; hovering it hides the gear; outside Bot mode it covers "Try it".
After: tutorial ring, inbox and gear sit in one row with no border, and hovering any of them keeps the others.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CugEyUiMxNL4Yvxg5gYRi4
Generated by Claude Code