Repository navigation
Offer full access from the approval card in a Bot's DM - #1625
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
marked this pull request as ready for review
October 14, 2026 05:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain
Why the change
Full access stays off for a new Bot, by the owner's decision: a new user should turn it on themselves with the warning in view. What tires a new user is the stream of approval cards, and nothing on a card said a switch exists.
Closes #1624
Special things to note
secret_cliandsecret_mcp_connect, which full access does not cover; Assignment cards, whose mode is fixed when they are created; cards in a Group; the pending-requests popover, where the open Channel may be a different one.companion-approval.test.tsgains five cases (offered for an Orchestrator Shell card in the DM and opens the workspace section; not offered for the two per-use tools, an Assignment card, or a Group). 13 tests in that file pass.pnpm lint,pnpm format:check,pnpm typecheckpass. Other suites were not run locally; CI runs them.Change outline
The card with the new action, and the settings it opens.
🤖 Generated with Claude Code