Skip to content

Offer full access from the approval card in a Bot's DM - #1625

Merged
DoodleBears merged 3 commits into
mainfrom
claude/full-access-entry
Oct 14, 2026
Merged

DoodleBears merged 3 commits into
mainfrom
claude/full-access-entry

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain

Why the change

Full access stays off for a new Bot, by the owner's decision: a new user should turn it on themselves with the warning in view. What tires a new user is the stream of approval cards, and nothing on a card said a switch exists.

Closes #1624

Special things to note

  • Merge risk: client only, one extra action on a card. Revert by reverting this PR.
  • A pending approval card shown in a Bot's DM for an ordinary tool call by the Bot's own chat Session gets one more action. It opens that Bot's workspace settings, where the full access switch and its red warning are. Nothing is turned on by the click.
  • Not shown on: the per-use cards for secret_cli and secret_mcp_connect, which full access does not cover; Assignment cards, whose mode is fixed when they are created; cards in a Group; the pending-requests popover, where the open Channel may be a different one.
  • Verification:
    • Automated: companion-approval.test.ts gains five cases (offered for an Orchestrator Shell card in the DM and opens the workspace section; not offered for the two per-use tools, an Assignment card, or a Group). 13 tests in that file pass. pnpm lint, pnpm format:check, pnpm typecheck pass. Other suites were not run locally; CI runs them.
    • Runtime, isolated Profile, real model: a Shell approval card in a test Bot's DM showed the entry; clicking it opened the Bot's settings on the workspace section with the switch off and the warning visible.
    • Human QA: not done.

Change outline

The card with the new action, and the settings it opens.

Approval card with the full access entry

Workspace settings opened from the card

🤖 Generated with Claude Code

DoodleBears and others added 2 commits October 14, 2026 05:51
Issue: #1624
Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Issue: #1624
Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@DoodleBears DoodleBears self-assigned this Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears
DoodleBears marked this pull request as ready for review October 14, 2026 05:43
@DoodleBears
DoodleBears merged commit 7a4b7a0 into main Oct 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offer full access from the approval card

1 participant