Repository navigation
Set up an MCP server from a one-sentence request - #1612
Merged
Merged
Conversation
Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Issue: #1611 Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #1611 Agent-Task: claude-code/local/9f51f103-7177-4bd0-8fd7-81d1ce39b98f Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain
Why the change
Asked in one sentence to set up an MCP server, a Bot did not use the secret card and the connect tool. It looked through Profile configuration with Shell, proposed editing DSH configuration, asked clarifying questions, or asked the Human to send the key in the chat.
Closes #1611
Special things to note
ask_secretat once, thensecret_mcp_connectwith the server's usual launcher; ask first only when the server is unclear; then list the tools. It also points tosecret_httpandsecret_cli.unknown prompt variable, because DSH treats it as a template variable. The paragraph avoids it and the prompt test now fails on any double brace other than the registered variables.@cablate/mcp-google-mapfor Google Maps). The start approval card shows the exact package, which is where the Human checks it.dsh-bot-agent-adapter.test.tsasserts the guidance is present and that the role prompt holds no stray template braces; 29 tests in that file pass.pnpm lint,pnpm format:check,pnpm typecheckpass. Other suites were not run locally; CI runs them.secret_mcp_connect.secret_mcp_connectwith annpx -y <package>launcher. The servers started and the Bots listed their tools; with synthetic keys the services then rejected real calls, as expected.uvx; a request for a service the model does not know.Change outline
No screen was changed; these show the flow a newly created Bot now follows after the single message "我想配置一下 Brave Search 的 MCP。", with a synthetic key.
These were taken on this branch, so the start card still shows the earlier wording of the remember button.
🤖 Generated with Claude Code