Repository navigation
Release the replaced Orchestrator handle - #1610
Conversation
When a Bot moves to a new Orchestrator Session, the adapter kept the Agent handle for the replaced Session until the Bot stopped. The runtime now asks the adapter to release every non-current Orchestrator handle that is not running. Issue: #1567 Agent-Task: claude/cloud/session_01Kb59UWGNphSuRtR8QUbxJW Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kb59UWGNphSuRtR8QUbxJW
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main carries two ADR-0194 records (#1596 and #1597), which fails the ADR number check. This ports the same renumbering as #1607 so CI can pass. Issue: #1567 Agent-Task: claude/cloud/session_01Kb59UWGNphSuRtR8QUbxJW Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kb59UWGNphSuRtR8QUbxJW
|
The Generated by Claude Code |
…-rqw5f9 # Conflicts: # CHANGELOG.md # CHANGELOG.zh.md # docs/dev/guides/private-input-ordinary.md # docs/dev/guides/private-input-ordinary.zh.md
Requested by Vain
Before: when a Bot moved to a new Orchestrator Session (for example after the old one was archived), BotHarness kept the Agent handle for the old Session in memory until the Bot stopped or DSH restarted. Every replacement added one more handle.
After: the old handle is released when the Bot moves to the new Session. A Session that is still running a turn is left alone.
How:
BotAgentAdaptergains an optionalreleaseSession(sessionId). The DSH adapter disposes the handle and its per-session state, and skips the call when that Session has an active run.#ensureOrchestratorcalls it for every Orchestrator root of the Bot other than the current one. Release failures only log a warning.Tests:
bot-runtime.test.tschecks that the archived Session is released after the replacement and that the current one never is.dsh-bot-agent-adapter.test.tschecks release, idempotence, unknown ids, and that a running Session is kept.Issue: #1567
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kb59UWGNphSuRtR8QUbxJW
Generated by Claude Code