Repository navigation
feat(avatar): flatter opt-in fully open speech mouth - #14
Merged
Merged
Conversation
Issue: #13 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (14)
📒 Files selected for processing (10)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #13 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
Resolve package version as 0.6.1 after upstream 0.6.0. Preserve both changelog entries and all upstream hair-part behavior. Issue: #13 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
Preserve upstream replacement parts and keep opt-in fully open speech artwork; resolve package and ledger conflicts as 0.7.1. Issue: #13 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13 | Agent claim | Refs Window Companion #1143
Task:
codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269· Refs #13Why the change
The fully open O-shaped speech mouth looked unnatural in Human DSH qualification, so an explicit new speech artwork version gives it a flatter opening while preserving the accepted half-open mouth.
Special things to note
speechMouthVersion: 2or revert the opt-in; small blast radius, only consumers explicitly selecting version 2 with speech layers see different fully open artwork. Review focus: exact unchanged default/version-1, saved, closed and half-open output across head turns.Change outline
Same face, 96px and 192px, dark
Left: accepted half-open; center: previous fully open; right: version 2. The horizontal center stays aligned.
Continuous same-cadence preview · Attribution and limits
Actual DSH — Chinese/light, 1559×865
Same Profile, saved face and exact complete new Bot reply, Host e4926548 integrated with main 78aba544. Before uses formal pixel-avatar0.5.0; After uses the owning source candidate e6f2c6c packed locally before its0.5.1 metadata bump. All four mouth states and both canonical replies were verified (227/199 samples). Background history, speech frame, timing and roaming position differ; these are real speech scenes rather than a frame-matched full-opening pair.
Continuous original speech · Continuous candidate speech · Sanitized qualification. Silent official MCP recordings, remux only; no synthetic SSE, mouth forcing, interpolation, audio or performance claim. Earlier old-Host editor type errors were resolved by latest main's existing0.5 compatibility, without a mouth-specific editor patch.
The public SVG-interface regression failed before implementation and passes afterward. At implementation head
ac9e25740e7ef33d1409b124d9bab23d16732ced, integrated with fetched main6d9add8, full verification/build passes (111 tests in 14 files), and the subsequently expanded speech regression passes all three tests. It compares unchanged default/version-1, static and non-open speech layers across all five animal species × five patterns × five turns, in addition to existing presets and geometry coverage. Golden fixtures remain unchanged. Implementation CI run 37859783658 passes, and separate Standards and Spec reviews report zero implementation findings. One pre-existing morph lint warning remains. Current head709408e adds only the following current-runtime evidence and its CI run 37861518672 passes.The earlier real DSH recordings retain their original source attribution and do not qualify new hair/animal/pattern combinations.
Current 0.10.1 candidate — real DEFAULT_RECIPE speech and dismissal
Fixed Host composition fc356883/main66d2767a uses the locally packed ac9e257 source and a QA-only Companion version-2 opt-in. No package is published or formally adopted. Host typecheck, focused renderer regression and build pass; current DEFAULT_RECIPE is saved through the existing authenticated appearance command.
Continuous84.867s current speech · Separate continuous83.433s native dismissal · Exact attribution, retained QA failures and limits. All four actual mouth states and the flattened open SVG layer are observed. The second recording focuses the exact header-close button and uses native Enter; the card disappears and saved expression returns in the same document. Canonical model replies and unchanged saved recipe are verified, including read-only postflight. The first script misselected source navigation and used a nonexistent final-read endpoint; the second script's strict repetitive-text wait timed out because the actual917-character reply differed from the request. These failures remain recorded, and neither full script is claimed wholly passing. Both clips are continuous silent official MCP output, remux only, including QA waiting. Console0errors; owned browsers closed. This qualifies current-package default-face runtime behavior, not every asset combination or performance.
Current candidate — actual stale feed and return
At the same fixed Host composition and owning candidate, one new exact3219-character canonical Bot reply drives real speech. Destroying/refusing the actual shared Companion SSE produces stale synchronization; all118 stale DOM samples show saved mouth, including a six-second hold. Already committed text continues revealing locally. Restoring that feed resumes speech on the same single card/document, retaining the original prefix and saved recipe. Other Host/model routes stay live.
Continuous48.767s actual cut/return · Sanitized qualification and limits. Silent official MCP output, remux only. Two intentional connection errors are recorded; owned browser/proxy closed. The initial test incorrectly required committed text to freeze; its failed report/video are retained and excluded, with no product rule or timer change. This qualifies current integrated-candidate mouth behavior, not standalone PR1180, audible cleanup, backgrounding, full-network outage, performance or formal dependency adoption. Evidence-only35e2636 CI passes; Standards and Spec review against latest fetched main6d9add8 each reports zero code/documentation findings. Human acceptance and adoption gates remain separate.
Human acceptance of the flatter shape and explicit publication approval remain open. No npm release or downstream formal dependency update has occurred.