docs(docs): quickstart as a TL;DR and Helm guide as the verified EKS walkthrough - #125
Conversation
Rewrite the quickstart around the three things you need: the CLI, a config file, and a server. Each part gets a short explanation and a link to the deep page instead of repeating it. Move what the quickstart used to own into the pages it now links to: CLI installation into CLI commands, the bundle checksum step into the Helm guide, and a health-check example into the deployment contract. Repoint the two links that used the old install anchor. Fixes #117 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The Kubernetes with Helm page was prose with no runnable sequence. It is now the end-to-end EKS guide: fourteen numbered steps from an empty AWS account to a governed agent, with gateway mode as a continuation. Code blocks are the verified ones; paths now point at the release bundle. The revision-bump comment and sed are dropped: the Control API strips revision before comparing baselines, so they did nothing. Content the old page held alone moves to the page that owns the topic: cert-manager and bring-your-own-certificates detail to Bring your own gateway, the invitation-link note to Manage users and invitations, and the config mount-path caveat to the chart README. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This pull request was created from a Blocks session. |
|
@cube /claude /reviewreview |
|
Both comments investigated. Results: Review comment enumeration & re-ranking1.
|
| # | Location | Bot | Mine (initial) | Mine (post-investigation) | Verdict |
|---|---|---|---|---|---|
| 1 | production.mdx:155 |
8 | 6 | 1 (−5 after investigation) | Invalid — acting on it causes a startup crashloop |
| 2 | runtime-contract.mdx:116 |
7 | 2 | 2 (unchanged) | Invalid — rationale factually wrong; edit would introduce an inaccuracy |
Nothing survives at severity ≥5, and neither is a merge blocker. The only defensible sliver in #1 is that the capability is inert for a reader who stops at step 8 — that argues for an inline clarifying comment, not a removal.
Per your instruction I've made no code changes and haven't touched the PR or its threads. Let me know which (if any) you want addressed and I'll fix + push those, resolve their threads, reply to the unpicked ones explaining the severity change, and add the picked/not-picked section to the PR summary.
|
User Message:
Done. Since nothing was picked, there were no fixes to make and no commits to push — the working tree is clean and the branch is unchanged at What I did on the PR:
Both were given a concrete reason (invalid after investigation) rather than "out of scope":
|
| service: | ||
| inferenceProxy: | ||
| annotations: | ||
| alb.ingress.kubernetes.io/healthcheck-path: /health |
There was a problem hiding this comment.
The inference proxy ALB health check should target /ready, not /health. The proxy's liveness endpoint (/health) always returns ok, while its readiness endpoint (/ready) returns 503 draining when the proxy is not ready to accept traffic. Using /health here means the ALB may send requests to a proxy that Kubernetes considers unready or that is draining during a rollout, which can cause failed inference requests. The chart's own readiness probe uses /ready, and the Control API and dashboard ALB annotations in step 5 already use their readiness paths (/ready and /api/health respectively).
Severity 7/10 · View on dashboard
| service: | ||
| inferenceProxy: | ||
| annotations: | ||
| alb.ingress.kubernetes.io/healthcheck-path: /health |
There was a problem hiding this comment.
The inference proxy ALB health check should use /ready instead of /health. I verified in services/inference-proxy/src/main.rs that /health unconditionally returns ok, while /ready returns 503 draining when the proxy is shutting down. Using /health here means the ALB can keep routing inference traffic to a pod that Kubernetes has already marked unready or that is draining during a rollout, causing failed requests. The chart's own readiness probe uses /ready (deploy/helm/templates/inference-proxy-deployment.yaml:86), and the dashboard/control-api ALB annotations above already use their readiness paths. Suggested fix: change this annotation to alb.ingress.kubernetes.io/healthcheck-path: /ready.
Severity 7/10 · View on dashboard
Fixes #117
Replaces #118, which was stacked on #116. Same two commits rebased onto
main, plus a merge ofmainafter #111 landed.Merge order. The Helm guide uses
inference_proxy_subdomainand theinference_proxy_hostnameoutput from #116, which is not onmainyet. Merge that first, or step 1 describes an input the module rejects.Quickstart
Now the short version: the three things you need (the CLI, a config file, a server), what each is for, and a link to the deep page. The
governancesection leads with what it controls: allowed agents, default model and settings, MCP servers, extensions, session capture. The three "how to deploy" cards from the old page are kept under the server section.Three things were only in the quickstart, so they moved:
BLUE_VERSIONpinning, and the installer's checksum note are now an Install section at the top of CLI commands.SHA256SUMScheck for the deployment bundle is now in the Helm guide.curlhealth checks are now under the deployment contract's health-check table.The two links that pointed at the old
#install-the-workstation-clianchor (Docker Compose page, README) now point at the new Install section.Kubernetes with Helm
Replaced with the verified end-to-end EKS walkthrough: a bundle download, then fourteen numbered steps from an empty AWS account to a governed agent, with gateway mode as a continuation of the same stack. Prose is one or two lines per step.
Code blocks are the verified ones, with these deliberate changes:
infra/awsfolder. The five path exports point at the current directory and at../../chart/blueinstead of a source checkout.revisionbump comment and the step 12sedare gone. The Control API stripsrevisionbefore comparing the mounted baseline to the stored one (normalized_governance_value), so bumping it did nothing, and Configure blue.yaml already says so. Thesedalso looked for a value nothing had written.Content the old page held alone moves to the page that owns the topic:
blue.config.mountPathcaveat: Helm chart README.Only
nextis changed;0.1.0is untouched.node scripts/check-content.mjspasses. A code-block diff of the new Helm page against the verified guide shows only the changes listed above. Not run:mint broken-links(not installed here).🤖 Generated with Claude Code