Skip to content

fix(abstract-eth): preserve version zero for CCR signing #9578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ralph-bitgo wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Draft

fix(abstract-eth): preserve version zero for CCR signing #9578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/abstract-eth/src/abstractEthLikeNewCoins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,7 +1706,7 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin implem
const txBuilder = this.getTransactionBuilder(params.common) as TransactionBuilder;
const txHex = buildResponse.txHex;
txBuilder.from(txHex);
if (buildResponse.walletVersion) {
if (buildResponse.walletVersion !== undefined) {
// If walletVersion is provided, set it in the txBuilder
txBuilder.walletVersion(buildResponse.walletVersion);
}
Expand Down
5 changes: 4 additions & 1 deletion modules/sdk-coin-ethlike/test/unit/ethlikeCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ describe('EthLike coin tests', function () {
const recoveryId = '0x1234567890abcdef';
nock(bitgo.microservicesUrl(`/api/recovery/v1/crosschain`)).get(`/${recoveryId}/buildtx`).reply(200, {
txHex: mockData.ccr[coin.name].txHex,
walletVersion: 0,
});
const walletPassphrase = TestBitGo.V2.TEST_RECOVERY_PASSCODE as string;
const params = {
Expand All @@ -75,6 +76,7 @@ describe('EthLike coin tests', function () {
const recoveryId = '0x1234567890abcdef';
nock(bitgo.microservicesUrl(`/api/recovery/v1/crosschain`)).get(`/${recoveryId}/buildtx`).reply(200, {
txHex: mockData.ccr[coin.name].txHex,
walletVersion: 0,
});
nock(bitgo.microservicesUrl(`/api/recovery/v1/crosschain`)).post(`/${recoveryId}/sign`).reply(200, {
coin: coin.name,
Expand All @@ -96,6 +98,7 @@ describe('EthLike coin tests', function () {
const recoveryId = '0x1234567890abcdef';
nock(bitgo.microservicesUrl(`/api/recovery/v1/crosschain`)).get(`/${recoveryId}/buildtx`).reply(200, {
txHex: mockData.ccr[coin.name].txHex,
walletVersion: 0,
});
const params = {
recoveryId,
Expand All @@ -112,7 +115,7 @@ describe('EthLike coin tests', function () {
coin: coin.name,
txHex: mockData.ccr[coin.name].txHex,
txid: mockData.ccr[coin.name].txid,
walletVersion: 1,
walletVersion: 0,
};

nock(bitgo.microservicesUrl(`/api/recovery/v1/crosschain`))
Expand Down
Loading