Repository navigation
feat(ui): add FloatingToggle primitive - #56
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
FloatingToggle, a single-cell floating card with anaria-pressedicon button. It is the on/off counterpart of thefloatingSegmentedControl, so hosts can place a toggle besideZoomControlswithout copying the card, cell and pressed styles.Changes
FloatingToggle(exported fromindex.ts).floating-control.tsgainsfloatingControlCellStateClassName(selected); thefloatingSegmentedControlnow uses it, so both controls share one set of selected/unselected styles. Rendered classes are unchanged.FloatingToggle.test.tsxand aCHANGELOG.mdentry under[Unreleased].Test plan
pnpm lintandpnpm build: pass.pnpm testinpackages/ui: 14 files, 115 tests pass (3 new).Screenshots
N/A (no playground page changed).
Risk
Intent
change, depth standard: new component plus a small refactor of shared class strings. An independent review compared the old and newSegmentedControlclasses and found no differences or other findings. No breaking changes. There is noSegmentedControlclass-output regression test.How to revert
Revert the merge commit.
Deployment notes
None. Not released here; a minor release (0.24.0) is a separate step.