Detect async children reliably in ReactiveSequence XML validation - #1194
Open
yurekami wants to merge 1 commit into
Open
Detect async children reliably in ReactiveSequence XML validation#1194yurekami wants to merge 1 commit into
yurekami wants to merge 1 commit into
Conversation
ReactiveSequence XML validation needs registration-time async metadata, but TreeNodeManifest is a public installed struct and changing its layout would create avoidable ABI churn. Reuse the existing manifest metadata channel to track async actions and controls, hide the internal marker from exported TreeNodesModel XML, and mark built-in async controls explicitly while exposing helpers for manual-builder and plugin registrations.\n\nConstraint: TreeNodeManifest is public API in installed headers and the project guide explicitly calls out ABI/back-compat review\nConstraint: VerifyXML runs before node instantiation and can only rely on registration metadata\nRejected: Add a public bool field to TreeNodeManifest | changes public struct layout for an internal validation detail\nRejected: Infer async controls from XML tag names | misses AsyncFallback and custom async registrations\nConfidence: high\nScope-risk: narrow\nDirective: Keep async validation metadata-based and reserve __bt_async for internal manifest state only\nTested: Conan Debug configure/build with VS2022 toolchain; gtest filter Reactive.*:BehaviorTreeFactory.*:PluginIssue1184Test.*:BasicTypes.TreeNodeManifestAsyncMetadata\nNot-tested: Full ctest discovery run from this shell without extra PATH injection for behaviortree_cppd.dll Signed-off-by: yurekami <yurekami@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreeNodeManifestlayoutVerifyXMLcount async action and control children from manifest metadataWhy
The validator compared normal user XML tags against base-class names, so multiple asynchronous children could pass under
ReactiveSequence. It also missed combinations such asAsyncFallbackplusAsyncSequence. This addresses #1184 without a public struct layout change.Verification
behaviortree_cpp_testReactive.*tests passedFixes #1184