Repository navigation
fix(write): reject reserved timestamp names in JSON - #82
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--format jsonaccepted reservedtimefield/tag names and case variants such asTimein columnar data. Arc can partially write these batches, so reject the names before sending a request. Canonicaltrow timestamps, lowercasetimecolumns and valid Unicode names remain supported. Tests cover single records, arrays and batches, including rejection before the write endpoint is called.Tested on macOS arm64 with Go 1.27.1:
go test -race -count=1 ./...,go vet ./...,go build ./...,gofmt -l .andgit diff --checkpassed. Regression tests reproduced the invalid uploads before the fix. Linux CI and the GoReleaser snapshot have not been run locally.