Repository navigation
fix(sample): reject unsafe manifest paths - #68
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject absolute, non-canonical and backslash-containing sample part keys before deriving local filenames.
path.Basepreserves backslashes, but Windows treats them as path separators, so a malformed manifest could target files outside the sample cache. Added regression coverage for traversal, absolute and Windows-style keys, plus a valid relative key. Verified on macOS withgo test -race -count=1 ./...,go vet ./...,go build ./...,gofmtandgit diff --check; the sample test package also cross-compiles for Windows amd64 and arm64, but was not run on Windows. The GoReleaser snapshot was not run locally because GoReleaser is unavailable.