Skip to content

feat(conversations): render Coordinator replies as Markdown - #371

Open
shingonoide wants to merge 2 commits into
mainfrom
conversations-markdown-replies
Open

shingonoide wants to merge 2 commits into
mainfrom
conversations-markdown-replies

Conversation

@shingonoide

Copy link
Copy Markdown
Contributor

Summary

Coordinator replies in the Project Conversation are now shown as formatted Markdown, so emphasis, lists and code spans render instead of showing their markers.

Guarantees

  • Only Coordinator replies are rendered as Markdown. Human messages, action events and approval records stay plain text, shown as typed.
  • Rendering reuses the existing safe Markdown renderer. Raw HTML and images are dropped, and a link keeps its markup only for http, https and mailto destinations.
  • The change is view-only. Stored conversation entries are not modified, and historical replies render the same way as new ones.

Verification

Verified at commit 84552a6c:

  • cargo test -p slashit-frontend passes.
  • cargo clippy -p slashit-frontend: no warnings in the changed files.
  • cargo clippy -p slashit-acceptance --all-targets --features run-acceptance -- -D warnings passes.
  • Desktop acceptance: conversations::a_coordinator_reply_renders_markdown_and_a_human_message_stays_literal passes, and shard 2 passes in full.
  • A probe of hostile Markdown (script and image tags, event-handler attributes, javascript: links in entity, percent, angle-bracket and reference forms, data: links) produced no executable markup or unsafe href.

Limitations

  • Long replies were not checked at multiple desktop widths.
  • The harness suite that CI runs with shard 2 was not run locally for this change.
  • render_chat_markdown and render_release_notes_markdown share one implementation. They keep separate names so each call site states its purpose.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: BarraDev/slashit
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 4e8ef5f
  • Layers: Repository YAML (base), Repository UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d1d0267f-4637-4d0f-b979-5628f17d3b96

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Walkthrough

Coordinator replies now render as Markdown with hard line breaks and the existing safety filtering. Human messages and other conversation events remain plain text. Tests cover Markdown formatting, literal Human message text, line breaks, unsafe links, raw HTML, and escaped code.

Change: Feature

Merge Risk: Minimal · previous review 84552

Coordinator replies now render as Markdown with the existing safety filtering, and other conversation entries are unchanged. No merge-blocking risk was found. A follow-up to key the history rows is optional.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title states the primary change: Coordinator replies in Project Conversation are now rendered as Markdown. The changeset adds render_chat_markdown and switches CoordinatorReply entries to Markdown…
Description check Passed The description states that Coordinator replies now render as formatted Markdown and that Human messages and other events stay plain text. It also covers the safety filtering, the view-only nature of …
Persistent State Integrity Passed The check fails only when changed code mutates persisted application state and can report success after a persistence failure, publish unpersisted state to shared memory, or let a stale read-modify-wr…
Recoverable Resource Lifecycle Passed The check is not applicable to PR #371 (BarraDev/slashit, by shingonoide, conversations-markdown-replies into main). The changed-file inventory has four modified files: `crates/slashit-acceptance/…
Platform Boundary Safety Passed The check fails only for Unix- or Windows-specific APIs, modules, types, or tests used on unsupported targets without gating, or for an evident cross-platform build failure. The pull request does not …
Full details: Title check

Explanation

The title states the primary change: Coordinator replies in Project Conversation are now rendered as Markdown. The changeset adds render_chat_markdown and switches CoordinatorReply entries to Markdown rendering, so the title matches the main change. The title uses the conventional feat(conversations) prefix. No title requirements were given beyond concise, primary-change wording, and the title meets them.

Full details: Description check

Explanation

The description states that Coordinator replies now render as formatted Markdown and that Human messages and other events stay plain text. It also covers the safety filtering, the view-only nature of the change, and verification steps. These all relate directly to the changeset.

Full details: Persistent State Integrity

Explanation

The check fails only when changed code mutates persisted application state and can report success after a persistence failure, publish unpersisted state to shared memory, or let a stale read-modify-write overwrite newer state. The PR's changed files are four: a shard manifest entry, an acceptance test, src/components/markdown.rs, and src/components/project_conversation.rs. The source diff shows view-only changes: - render_chat_markdown in markdown.rs calls the existing render(src, true). It adds no storage or write path. - In project_conversation.rs, the change selects Markdown rendering for CoordinatorReply entries only. It alters the view! body and adds no call that writes, saves, or updates conversation data. - The acceptance test and shard manifest add test code only. No changed code writes to persisted state, shared memory, or a store. The check therefore does not apply to this change. The PR description also states that stored entries are not modified.

Full details: Recoverable Resource Lifecycle

Explanation

The check is not applicable to PR #371 (BarraDev/slashit, by shingonoide, conversations-markdown-replies into main). The changed-file inventory has four modified files: crates/slashit-acceptance/shard-manifest.txt, crates/slashit-acceptance/tests/product_acceptance/conversations.rs, src/components/markdown.rs, and src/components/project_conversation.rs. The code diff shows the following: - markdown.rs adds render_chat_markdown, which calls the existing render(src, true), plus a unit test. - project_conversation.rs selects Markdown rendering only for CoordinatorReply entries and otherwise keeps the plain-text path. The change is view-only. - The manifest adds one acceptance test name to shard 2. A keyword search over the changed files found worktree, cleanup, and delete references. They are either pre-existing acceptance tests that the PR does not touch or existing on_cleanup UI timer hooks. None of them is changed by this PR. The PR does not alter any code that clears, destroys, or fails to recover persisted resource references, and it adds no cleanup or retry path.

Full details: Platform Boundary Safety

Explanation

The check fails only for Unix- or Windows-specific APIs, modules, types, or tests used on unsupported targets without gating, or for an evident cross-platform build failure. The pull request does not introduce such code. Evidence: - The changed-file inventory has four modified files: shard-manifest.txt, tests/product_acceptance/conversations.rs, src/components/markdown.rs, and src/components/project_conversation.rs. - The src changes add render_chat_markdown, which calls the existing render(src, true). They add a prose CSS class and a matches! on CoordinatorReply. They contain no unix, windows, target_os, std::os, or #[cfg] references. The changed src files use no platform-specific API. - The new acceptance test uses the same harness calls as the existing conversation tests: FakeAgent::install, set_child_env("PATH", …), and OsString conversion. Those calls are platform-neutral. - tests/product_acceptance.rs is gated with #![cfg(target_os = "linux")] at line 25. It declares mod conversations; at line 55. The new test therefore compiles only on Linux, like the other tests in that suite. It introduces no new ungated platform dependency. No cross-platform compile failure is evident in the changed build path.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: BarraDev/slashit
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 4e8ef5f
  • Layers: Repository YAML (base), Repository UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 96a4dd9c-0712-4ac8-97c3-8786b917ac50
Commits

Reviewing files that changed from the base of the PR and between 4e8ef5f and 84552a6.

Files selected for processing: 4

  • crates/slashit-acceptance/shard-manifest.txt
  • crates/slashit-acceptance/tests/product_acceptance/conversations.rs
  • src/components/markdown.rs
  • src/components/project_conversation.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread src/components/project_conversation.rs Resolved
Markdown links in Coordinator replies are clickable, which src/AGENTS.md
requires to be rendered from a keyed list. Each history entry is now a keyed
row whose event body is a memo, so a refresh that leaves a row unchanged does
not rebuild its links.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant